Re-factor how the ESLint no-var rule is enabled in the src/ folder
#12441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies/consolidates the ESLint configuration slightly in the `src/` folder, and prevents the addition of any new files where `var` is being used.[1] Hence we no longer need to manually add `/* eslint no-var: error */` in files, which is easy to forget, and can instead disable the rule in the `src/core/` files where `var` is still in use. --- [1] Obviously the `no-var` rule can, in the same way as every other rule, be disabled on a case-by-case basis where actually necessary.
|
/botio lint |
From: Bot.io (Linux m4)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/5c28b3c1d420c81/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/6d80d8dca258ccd/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/5c28b3c1d420c81/output.txt Total script time: 2.20 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/6d80d8dca258ccd/output.txt Total script time: 2.96 mins
|
timvandermeij
approved these changes
Oct 3, 2020
|
Good idea; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies/consolidates the ESLint configuration slightly in the
src/folder, and prevents the addition of any new files wherevaris being used.[1]Hence we no longer need to manually add
/* eslint no-var: error */in files, which is easy to forget, and can instead disable the rule in thesrc/core/files wherevaris still in use.[1] Obviously the
no-varrule can, in the same way as every other rule, be disabled on a case-by-case basis where actually necessary.