Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade acorn to version 8 #12451

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Conversation

Snuffleupagus
Copy link
Collaborator

I've run gulp mozcentral, gulp generic, and gulp generic-es5 with master respectively this patch and then diffed the build output. With the (obvious) exception of increased version/build numbers, there were no actual changes from the updated Acorn version.

I've run `gulp mozcentral`, `gulp generic`, and `gulp generic-es5` with `master` respectively this patch and then diffed the build output. With the (obvious) exception of increased version/build numbers, there were no actual changes from the updated Acorn version.
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Oct 6, 2020

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/9ba1c0e6e1e73e7/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Oct 6, 2020

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/9ba1c0e6e1e73e7/output.txt

Total script time: 3.53 mins

Published

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Oct 6, 2020

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/a8487082aecf65a/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Oct 6, 2020

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/8a66167c099a4bd/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Oct 6, 2020

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/a8487082aecf65a/output.txt

Total script time: 25.37 mins

  • Font tests: Passed
  • Unit tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/a8487082aecf65a/reftest-analyzer.html#web=eq.log

locations: true,
sourceFile: ctx.sourceFile,
sourceType: "module",
};
var codegenOptions = {
format: format,
parse: acorn.parse,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this was the part I missed when I fiddled with this before...

@timvandermeij timvandermeij merged commit fd1d9cc into mozilla:master Oct 6, 2020
@timvandermeij
Copy link
Contributor

Thanks!

@Snuffleupagus Snuffleupagus deleted the acorn-8 branch October 7, 2020 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants