Upgrade terser to version 5
#12454
Merged
Upgrade terser to version 5
#12454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only significant change is that the `minify` command is now asynchronous, which we can handle easily by simply making the containing functions `async`. Based on https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/async_function#Browser_compatibility, using `async`/`await` in the gulpfile should no longer be an issue as far as I can tell.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/b245cef36e05ef1/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/b245cef36e05ef1/output.txt Total script time: 3.53 mins Published |
timvandermeij
approved these changes
Oct 7, 2020
|
Nice, another one done! |
|
Thanks for landing this, and the other one too! I'm not going to attempt the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only significant change is that the
minifycommand is now asynchronous, which we can handle easily by simply making the containing functionsasync.Based on https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/async_function#Browser_compatibility, using
async/awaitin the gulpfile should no longer be an issue as far as I can tell.