Handle WorkerTasks, and various PDF document properties, correctly in the "SaveDocument" handler in src/core/worker.js
#12477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in the "SaveDocument" handler in `src/core/worker.js` - Actually register/unregister the `WorkerTask`s, used when saving each page, correctly. To prevent issues when terminating the Worker, we purposely wait for all running `WorkerTask`s to complete first. Hence we need to actually handle `WorkerTask`s the same way in "SaveDocument" as in the rest of this file, see e.g. "GetOperatorList" and "GetTextContent". - Access `PDFDocument` properties in a generally safe/consistent way. While the current code works fine, given how the PDF document is being loaded, it still seems like a very good idea to be *consistent* in how we access these kind of properties (since in general you need to avoid `MissingDataException` everywhere in this file). - Change a variable name, since there's essentially no precedent in the code-base for *local* variable names to start with an underscore.
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/b2381612e983687/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/fded4ee8c1976e6/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/b2381612e983687/output.txt Total script time: 4.22 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/fded4ee8c1976e6/output.txt Total script time: 5.21 mins
|
timvandermeij
approved these changes
Oct 13, 2020
|
Thank you for cleaning this up a bit! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually register/unregister the
WorkerTasks, used when saving each page, correctly.To prevent issues when terminating the Worker, we purposely wait for all running
WorkerTasks to complete first. Hence we need to actually handleWorkerTasks the same way in "SaveDocument" as in the rest of this file, see e.g. "GetOperatorList" and "GetTextContent".Access
PDFDocumentproperties in a generally safe/consistent way.While the current code works fine, given how the PDF document is being loaded, it still seems like a very good idea to be consistent in how we access these kind of properties (since in general you need to avoid
MissingDataExceptioneverywhere in this file).Change a variable name, since there's essentially no precedent in the code-base for local variable names to start with an underscore.