Fix a couple of edge-cases in PDFViewerApplication._initializeJavaScript (PR 12432 follow-up)
#12522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ript` (PR 12432 follow-up) - Return early in `PDFViewerApplication._initializeJavaScript` for PDF documents without any `fieldObjects`, which is the vast majority of all documents, to prevent errors when trying to parse a non-existent object. - Similar to the other `PDFViewerApplication._initialize*` methods, ignore the `fieldObjects` if the document was closed before the data resolved. - Fix the JSDoc comment for the `generateRandomStringForSandbox` helper function, since there's currently a bit too much copy-and-paste going on :-) - Change `FirefoxScripting` to a class with static methods, which is consistent with the surrounding code in `web/firefoxcom.js`.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/4256d5d1146b7f4/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/4256d5d1146b7f4/output.txt Total script time: 3.98 mins Published |
timvandermeij
approved these changes
Oct 24, 2020
|
Thank you for improving this code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return early in
PDFViewerApplication._initializeJavaScriptfor PDF documents without anyfieldObjects, which is the vast majority of all documents, to prevent errors when trying to parse a non-existent object.Similar to the other
PDFViewerApplication._initialize*methods, ignore thefieldObjectsif the document was closed before the data resolved.Fix the JSDoc comment for the
generateRandomStringForSandboxhelper function, since there's currently a bit too much copy-and-paste going on :-)Change
FirefoxScriptingto a class with static methods, which is consistent with the surrounding code inweb/firefoxcom.js.