Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard import statements more when running the unit-tests #12539

Merged
merged 3 commits into from
Oct 27, 2020

Conversation

Snuffleupagus
Copy link
Collaborator

Please refer to the individual commit messages for additional information.

This way it's no longer necessary to load it as a script in the html-files.
…g the unit-tests

The unit-test files themselves shouldn't be loaded until Jasmine has been setup/configured, however that doesn't matter for the "normal" PDF.js library files. Hence we can simply `import` them in the standard way.
…it-test

The description *itself* didn't escape the control characters correctly, leading to line-breaks being inserted in the test logs.
@Snuffleupagus
Copy link
Collaborator Author

/botio unittest

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/1ca2a80247b41bd/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/1ca2a80247b41bd/output.txt

Total script time: 3.41 mins

  • Unit Tests: FAILED

@Snuffleupagus
Copy link
Collaborator Author

/botio fonttest

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_fonttest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/5134d47fc19680e/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/5134d47fc19680e/output.txt

Total script time: 1.74 mins

  • Font Tests: Passed

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/bd8d5c49f87bd32/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/bd8d5c49f87bd32/output.txt

Total script time: 24.54 mins

  • Font tests: Passed
  • Unit tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/bd8d5c49f87bd32/reftest-analyzer.html#web=eq.log

@timvandermeij timvandermeij merged commit 08b00c1 into mozilla:master Oct 27, 2020
@timvandermeij
Copy link
Contributor

Looks much better. Thanks!

@Snuffleupagus Snuffleupagus deleted the TestReporter-import branch October 28, 2020 09:25
@Snuffleupagus
Copy link
Collaborator Author

Looks much better. Thanks!

Thank you for reviewing/landing this, and the other recent test-related patches.

It's really fascinating how code sort of "ages", like in the font-tests, when you don't touch it for a couple of years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants