-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS -- Send events to the sandbox from annotation layer #12635
Conversation
714d697
to
a1a17fe
Compare
d47eae6
to
f1488d1
Compare
Will this be tested in another patch or are there some manual tests for now? |
f1488d1
to
27fda47
Compare
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://3.101.106.178:8877/1a6a3418e6ee33c/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.67.70.0:8877/0e687f8479d0e72/output.txt |
27fda47
to
10a5027
Compare
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/0e687f8479d0e72/output.txt Total script time: 14.26 mins
Image differences available at: http://54.67.70.0:8877/0e687f8479d0e72/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/1a6a3418e6ee33c/output.txt Total script time: 15.44 mins
Image differences available at: http://3.101.106.178:8877/1a6a3418e6ee33c/reftest-analyzer.html#web=eq.log |
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://3.101.106.178:8877/89c4038faf9b8a1/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/576d6ae9e14e8d7/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/576d6ae9e14e8d7/output.txt Total script time: 13.86 mins
Image differences available at: http://54.67.70.0:8877/576d6ae9e14e8d7/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/89c4038faf9b8a1/output.txt Total script time: 14.86 mins
Image differences available at: http://3.101.106.178:8877/89c4038faf9b8a1/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+ with update for the window event
web/app.js
Outdated
@@ -1475,6 +1475,12 @@ const PDFViewerApplication = { | |||
return; // The document was closed while the metadata resolved. | |||
} | |||
} | |||
window.addEventListener("mousedown", event => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes the annotation layer dependent on the viewer. Can we move this into the annotation layer and not store the property on the window?
0443948
to
445706b
Compare
445706b
to
6502ae8
Compare
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/4bbb7a2883db696/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://3.101.106.178:8877/55771af155e5bf6/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/4bbb7a2883db696/output.txt Total script time: 25.63 mins
Image differences available at: http://54.67.70.0:8877/4bbb7a2883db696/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/55771af155e5bf6/output.txt Total script time: 26.17 mins
|
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://3.101.106.178:8877/60b2ae269947d39/output.txt |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/60b2ae269947d39/output.txt Total script time: 27.02 mins
Image differences available at: http://3.101.106.178:8877/60b2ae269947d39/reftest-analyzer.html#web=eq.log |
No description provided.