Check the top-level /Pages dictionary when finding the trailer in XRef.indexObjects (issue 12402)
#12662
Conversation
…ef.indexObjects` (issue 12402) In addition to the existing /Root and /Pages validation, also check that the /Pages-entry actually is a dictionary and that it has a valid /Count-entry. This way we can avoid picking a trailer candidate which e.g. the `Catalog.numPages` getter will just end up rejecting, thus breaking PDF document loading completely.
Snuffleupagus
force-pushed
the
issue-12402
branch
from
029cb40
to
8a132f5
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/3d668142fd8e7ce/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/cf31ebbdfa2b4ec/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/3d668142fd8e7ce/output.txt Total script time: 26.11 mins
Image differences available at: http://54.67.70.0:8877/3d668142fd8e7ce/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/cf31ebbdfa2b4ec/output.txt Total script time: 29.11 mins
Image differences available at: http://3.101.106.178:8877/cf31ebbdfa2b4ec/reftest-analyzer.html#web=eq.log |
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/268014f4b87d074/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/268014f4b87d074/output.txt Total script time: 4.24 mins Published |
|
Looks good; thanks! /botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/15962e502b71666/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 2 Live output at: http://3.101.106.178:8877/bebbf698b36cd4f/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/15962e502b71666/output.txt Total script time: 25.41 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/bebbf698b36cd4f/output.txt Total script time: 29.56 mins
|
In addition to the existing /Root and /Pages validation, also check that the /Pages-entry actually is a dictionary and that it has a valid /Count-entry.
This way we can avoid picking a trailer candidate which e.g. the
Catalog.numPagesgetter will just end up rejecting, thus breaking PDF document loading completely.Fixes #12402