[Regression] Prevent the *built* pdf.scripting.js/pdf.sandbox.js files from accidentally including most of the main-thread code (PR 12631 follow-up)
#12693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…files from accidentally including most of the main-thread code (PR 12631 follow-up) *This is a recent regression, which I stumbled upon while working on cleaning-up the gulpfile related to `pdf.sandbox.js` building.* By placing the `ColorConverters` functionality in the `src/display/display_utils.js` file, you end up including a *significant* chunk of the `pdf.js` file in the built `pdf.scripting.js`/`pdf.sandbox.js` files. Given that I cannot imagine that this was actually intended, since it inflates the built files with unnecessary/unused code, this moves `ColorConverters` to a new file instead (thus breaking the dependencies). To hopefully reduce the risk future bugs, along these lines, a big comment is also placed at the top of the new file. Finally, the `ColorConverters` is converted to a class with static methods, since this felt slightly cleaner overall.
calixteman
approved these changes
Dec 4, 2020
|
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/5c26286267f061f/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/05e464eda16efaf/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/05e464eda16efaf/output.txt Total script time: 3.58 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/5c26286267f061f/output.txt Total script time: 4.76 mins
|
timvandermeij
approved these changes
Dec 4, 2020
|
Thanks! |
nmtigor
reviewed
Jun 6, 2022
| } | ||
|
|
||
| static CMYK_HTML(components) { | ||
| return this.RGB_HTML(this.CMYK_RGB(components)); |
There was a problem hiding this comment.
Should this be
return this.RGB_HTML(this.CMYK_RGB(components).slice(1));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a recent regression, which I stumbled upon while working on cleaning-up the gulpfile related to
pdf.sandbox.jsbuilding.By placing the
ColorConvertersfunctionality in thesrc/display/display_utils.jsfile, you end up including a significant chunk of thepdf.jsfile in the builtpdf.scripting.js/pdf.sandbox.jsfiles.Given that I cannot imagine that this was actually intended, since it inflates the built files with unnecessary/unused code, this moves
ColorConvertersto a new file instead (thus breaking the dependencies).To hopefully reduce the risk future bugs, along these lines, a big comment is also placed at the top of the new file.
Finally, the
ColorConvertersis converted to a class with static methods, since this felt slightly cleaner overall.