Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix automatic zoom under spread mode #12700

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Fix automatic zoom under spread mode #12700

merged 1 commit into from
Dec 14, 2020

Conversation

calixteman
Copy link
Contributor

@calixteman calixteman commented Dec 6, 2020 •
edited by timvandermeij
Loading

Fixes #12699.

@calixteman
Copy link
Contributor Author

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Dec 6, 2020

From: Bot.io (Linux m4)

Received

Command cmd_preview from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/35a1bdc20b78ea6/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Dec 6, 2020

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/35a1bdc20b78ea6/output.txt

Total script time: 4.22 mins

Published

Snuffleupagus
Snuffleupagus requested changes Dec 7, 2020
View reviewed changes
web/base_viewer.js Outdated Show resolved Hide resolved
web/base_viewer.js Outdated Show resolved Hide resolved
@timvandermeij
Copy link
Contributor

timvandermeij commented Dec 9, 2020 •
edited
Loading

Those commits look related to each other. Should they be squashed into one?

@calixteman
Copy link
Contributor Author

Those commits look related to each other. Should they be squashed into one?

Yes they can.

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 1

Live output at: http://54.67.70.0:8877/ecf906c292fbec5/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/ecf906c292fbec5/output.txt

Total script time: 4.34 mins

Published

timvandermeij
timvandermeij reviewed Dec 11, 2020
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with this final comment addressed.

web/base_viewer.js Show resolved Hide resolved
Snuffleupagus
Snuffleupagus reviewed Dec 11, 2020
View reviewed changes
web/base_viewer.js Outdated Show resolved Hide resolved
@calixteman
Fix automatic zoom under spread mode (mozilla#12699)
785487c 
Reset scale when update spread mode
@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/ac75ad1eb161ddd/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/ac75ad1eb161ddd/output.txt

Total script time: 4.19 mins

Published

@timvandermeij timvandermeij merged commit a825b91 into mozilla:master Dec 14, 2020
@timvandermeij
Copy link
Contributor

Thank you for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus requested changes

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees
No one assigned
Labels
viewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automatic zoom not correct with odd or even spreads
4 participants
@calixteman @pdfjsbot @timvandermeij @Snuffleupagus