Stop running gulp components as part of the unit-tests
#12761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `gulp components` task is only necessary when running the reference-tests, since they use the `SimpleLinkService` during the `annotationLayer` sub-tests. However, unit-tests don't actually use any part of the `gulp components` build, and we can thus reduce the overall runtime of the standalone unit-tests by not building unnecessary files.
|
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/3e5fcece05cedb4/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/5420f827eb033bb/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/5420f827eb033bb/output.txt Total script time: 3.70 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/3e5fcece05cedb4/output.txt Total script time: 4.68 mins
|
timvandermeij
approved these changes
Dec 19, 2020
|
Nice find! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
gulp componentstask is only necessary when running the reference-tests, since they use theSimpleLinkServiceduring theannotationLayersub-tests.However, unit-tests don't actually use any part of the
gulp componentsbuild, and we can thus reduce the overall runtime of the standalone unit-tests by not building unnecessary files.