Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary dir-dependent CSS rules, and add a missing CSS variable (PR 11077 follow-up) #12807

Merged
merged 1 commit into from
Jan 3, 2021
Merged

Remove unnecessary dir-dependent CSS rules, and add a missing CSS variable (PR 11077 follow-up) #12807

merged 1 commit into from
Jan 3, 2021

Commits on Jan 3, 2021

  1. Remove unnecessary dir-dependent CSS rules, and add a missing CSS v… 

    …ariable (PR 11077 follow-up)

With the updated default viewer UI, a couple of `dir`-dependent CSS rules have now become redundant since *identical* rules are being specified for both LTR and RTL mode.

Furthermore, there's also some unnecessary re-defining of the `toolbarButton`/`secondaryToolbarButton`-icon related CSS rules.

Finally, for the toggle-buttons there's a particular styling applied to the `:hover:active` state, however the color wasn't defined with CSS variables.
    @Snuffleupagus
    Snuffleupagus committed Jan 3, 2021
    Configuration menu
    Copy the full SHA
    94f1020 View commit details
    Browse the repository at this point in the history