Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to fix TypeScript definitions for the es5-build in pdfjs-dist (issue 12872) #12834

Merged
merged 1 commit into from
Jan 8, 2021
Merged

Try to fix TypeScript definitions for the es5-build in pdfjs-dist (issue 12872) #12834

merged 1 commit into from
Jan 8, 2021

Commits on Jan 8, 2021

  1. Try to fix TypeScript definitions for the es5-build in pdfjs-dist (is… 

    …sue 12872)

Given that we're already using the `external/dist/` folder for things we simply want to copy to pdfjs-dist during building, this patch *should* hopefully work since it's based on the suggestion in issue 12827.

As long as this only requires a *single/small* file, to fix the TypeScript definitions in es5-builds, this solution seem acceptable as far as I'm concerned. (Although, please note that I don't know enough about TypeScript to actually test the patch.)
    @Snuffleupagus
    Snuffleupagus committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    aabf768 View commit details
    Browse the repository at this point in the history