Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split the classes in src/core/obj.js into separate files #13235

Merged
merged 10 commits into from
Apr 13, 2021
Merged

Split the classes in src/core/obj.js into separate files #13235

merged 10 commits into from
Apr 13, 2021

Commits on Apr 13, 2021

  1. Move the ObjectLoader from src/core/obj.js and into its own file 

    The size of the `src/core/obj.js` file has increased slowly over the years, and it also contains a fair amount of *distinct* functionality.
In order to improve readability and make it easier to navigate through the code, this patch moves the `ObjectLoader` into its own file.
    @Snuffleupagus
    Snuffleupagus committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    604cd6d View commit details
    Browse the repository at this point in the history

  2. Covert the ObjectLoader to a "normal" class

    @Snuffleupagus
    Snuffleupagus committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    6a93568 View commit details
    Browse the repository at this point in the history

  3. Move the FileSpec from src/core/obj.js and into its own file 

    The size of the `src/core/obj.js` file has increased slowly over the years, and it also contains a fair amount of *distinct* functionality.
In order to improve readability and make it easier to navigate through the code, this patch moves the `FileSpec` into its own file.
    @Snuffleupagus
    Snuffleupagus committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    e02d17d View commit details
    Browse the repository at this point in the history

  4. Convert the FileSpec to a "normal" class

    @Snuffleupagus
    Snuffleupagus committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    22a066e View commit details
    Browse the repository at this point in the history

  5. Enable the no-var rule in the src/core/file_spec.js file

    @Snuffleupagus
    Snuffleupagus committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    92141e0 View commit details
    Browse the repository at this point in the history

  6. Move NameTree/NumberTree from src/core/obj.js and into its own … 

    …file

The size of the `src/core/obj.js` file has increased slowly over the years, and it also contains a fair amount of *distinct* functionality.
In order to improve readability and make it easier to navigate through the code, this patch moves `NameTree`/`NumberTree` into its own file.
    @Snuffleupagus
    Snuffleupagus committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    24e5ecd View commit details
    Browse the repository at this point in the history

  7. Move the XRef from src/core/obj.js and into its own file 

    The size of the `src/core/obj.js` file has increased slowly over the years, and it also contains a fair amount of *distinct* functionality.
In order to improve readability and make it easier to navigate through the code, this patch moves the `XRef` into its own file.
    @Snuffleupagus
    Snuffleupagus committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    e8750cf View commit details
    Browse the repository at this point in the history

  8. Convert the XRef to a "normal" class

    @Snuffleupagus
    Snuffleupagus committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    bc828cd View commit details
    Browse the repository at this point in the history

  9. Enable the no-var rule in the src/core/xref.js file

    @Snuffleupagus
    Snuffleupagus committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    088a55f View commit details
    Browse the repository at this point in the history

  10. Rename the src/core/obj.js file to src/core/catalog.js 

    Now that only the `Catalog` remains in this file, after the previous patches, it makes sense to rename the file to reduce confusion.
    @Snuffleupagus
    Snuffleupagus committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    1d6d476 View commit details
    Browse the repository at this point in the history