Re-factor and convert the code in src/core/pattern.js to use standard classes
#13377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…core/pattern.js` Neither the `type` or the `cs` properties are used outside of the "constructors", and we can thus remove them.[1] Note that a lot of this code is very old, and that it actually predates the main/worker-thread split before which the *same* file was used on both the main- *and* worker-threads. --- [1] On the main-thread, a similar `type` property was removed in PR 12591.
Snuffleupagus
force-pushed
the
pattern-class
branch
2 times, most recently
from
5a0cee4
to
9515d8c
Compare
Note that this patch only covers `Pattern` and `MeshStreamReader`, since the `Shadings`-implementation required additional re-factoring.
Snuffleupagus
force-pushed
the
pattern-class
branch
from
9515d8c
to
ad8cb5c
Compare
…standard classes This patch replaces the old structure with a abstract base-class, which the new RadialAxial/Mesh-shading classes then inherit from.[1] The old `MeshClosure` can now be removed, since it's not necessary any more, and most of the functions inside of it are now instead methods on the new `MeshShading` class. This is particularly nice, in my opinion, since we previously were *manually* passing around a reference to the current `Mesh`-instance. --- [1] If we want/need to, in the future, split e.g. the Mesh-handling into multiple classes that should now be easy to do.
Snuffleupagus
force-pushed
the
pattern-class
branch
from
ad8cb5c
to
ebe3ee4
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/e2cd2b7aed2ff3a/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/157bc9d1e6e1eed/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/e2cd2b7aed2ff3a/output.txt Total script time: 26.30 mins
Image differences available at: http://54.67.70.0:8877/e2cd2b7aed2ff3a/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/157bc9d1e6e1eed/output.txt Total script time: 29.80 mins
Image differences available at: http://3.101.106.178:8877/157bc9d1e6e1eed/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
May 14, 2021
|
Looks a lot better, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.