Remove some, with Prettier 2.3.0, unnecessary // prettier-ignore comments
#13401
Conversation
…comments To get the maximum benefit from something like Prettier, you obviously don't want to disable the automatic formatting unless absolutely necessary. When we added Prettier there were a number of cases, mostly involving larger Arrays, which required disabling of the automatic formatting for overall readability and/or to not break inline comments. With changes in Prettier version `2.3.0`, see [the release notes](https://prettier.io/blog/2021/05/09/2.3.0.html#concise-formatting-of-number-only-arrays-10106httpsgithubcomprettierprettierpull10106-10160httpsgithubcomprettierprettierpull10160-by-thorn0httpsgithubcomthorn0), there's now better formatting support for Arrays containing only numbers. Hence we can now remove a number of `// prettier-ignore` comments, and thus get the benefit of automatic formatting in (slightly) more of the code-base.
Snuffleupagus
force-pushed
the
rm-some-prettier-ignore
branch
from
80f7891
to
1a8d05f
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/66707f5d0df6ccc/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/27494848c6af72e/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/66707f5d0df6ccc/output.txt Total script time: 26.36 mins
Image differences available at: http://54.67.70.0:8877/66707f5d0df6ccc/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/27494848c6af72e/output.txt Total script time: 30.08 mins
Image differences available at: http://3.101.106.178:8877/27494848c6af72e/reftest-analyzer.html#web=eq.log |
|
Thank you for doing this! |
|
@timvandermeij As always, thank you for landing my patches :-) Somewhat unrelated, but is it too soon to start thinking about creating a new release now? Historically we've probably, more than once, gone a bit too long between releases at times. Having releases happening around e.g. every 6-8 weeks[1] would mean that users get access to bug fixes and new features much quicker (since many users seem to prefer the stable versions). [1] Note how the release cycle of e.g. Firefox is even shorter nowadays, see https://wiki.mozilla.org/Release_Management/Calendar |
To get the maximum benefit from something like Prettier, you obviously don't want to disable the automatic formatting unless absolutely necessary. When we added Prettier there were a number of cases, mostly involving larger Arrays, which required disabling of the automatic formatting for overall readability and/or to not break inline comments.
With changes in Prettier version
2.3.0, see the release notes, there's now better formatting support for Arrays containing only numbers. Hence we can now remove a number of// prettier-ignorecomments, and thus get the benefit of automatic formatting in (slightly) more of the code-base.