Fix scrolling of search results in documents with marked content (bug 1714183) #13482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unction This code was added in PR 3968, apparently in order to fix scrolling of search results in HiDPI-mode. However, after PR 4570 nothing is setting these `dataset`-properties any more and this is thus dead code which should be removed. (If that change had broken scrolling of search results in HiDPI-mode, you'd really expect that it'd been reported and fixed a long time ago.)
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/84b07c2a1621fac/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/b58396396c6c706/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/b58396396c6c706/output.txt Total script time: 4.37 mins
|
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/84b07c2a1621fac/output.txt Total script time: 5.03 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/75dea72e48633ba/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/75dea72e48633ba/output.txt Total script time: 3.79 mins Published |
…714183) This regressed in PR 13171, since the `span`s with the marked content identifiers interfere with scrolling of search results.
Snuffleupagus
force-pushed
the
scrollMatches-fix
branch
from
a852561
to
29e6930
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regressed in PR #13171, since the
spans with the marked content identifiers interfere with scrolling of search results.Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1714183