Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XFA - Display rectangle, line and arc #13495

Merged
merged 1 commit into from
Jun 9, 2021
Merged

XFA - Display rectangle, line and arc #13495

merged 1 commit into from
Jun 9, 2021

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman calixteman marked this pull request as draft June 4, 2021 18:32
@calixteman calixteman marked this pull request as ready for review June 5, 2021 14:21
brendandahl
brendandahl approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@brendandahl brendandahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ with a test

@calixteman calixteman force-pushed the draws branch 2 times, most recently from 90ceafe to 76381c3 Compare June 9, 2021 13:25
@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Jun 9, 2021

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/459def13c726572/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 9, 2021

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/258640c18bd7ae4/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 9, 2021

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/258640c18bd7ae4/output.txt

Total script time: 4.54 mins

  • Font tests: Passed
  • Unit tests: FAILED
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/258640c18bd7ae4/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Jun 9, 2021

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/459def13c726572/output.txt

Total script time: 5.01 mins

  • Font tests: Passed
  • Unit tests: FAILED
  • Integration Tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/459def13c726572/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Jun 9, 2021

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/2bb8f9b608ac7e2/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 9, 2021

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://3.101.106.178:8877/cb57e8e7153e772/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 9, 2021

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/2bb8f9b608ac7e2/output.txt

Total script time: 26.05 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/2bb8f9b608ac7e2/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Jun 9, 2021

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/cb57e8e7153e772/output.txt

Total script time: 29.62 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/cb57e8e7153e772/reftest-analyzer.html#web=eq.log

@calixteman calixteman merged commit f2b9f0d into mozilla:master Jun 9, 2021
@calixteman
Copy link
Contributor Author

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Jun 9, 2021

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/04a44b1c050e353/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 9, 2021

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 1

Live output at: http://3.101.106.178:8877/ae3561554b4807b/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 9, 2021

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/04a44b1c050e353/output.txt

Total script time: 22.98 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@calixteman calixteman deleted the draws branch June 9, 2021 15:07
@pdfjsbot
Copy link

pdfjsbot commented Jun 9, 2021

From: Bot.io (Windows)

Success

Full output at http://3.101.106.178:8877/ae3561554b4807b/output.txt

Total script time: 27.12 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandahl brendandahl brendandahl approved these changes

Assignees
No one assigned
Labels
form-xfa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@calixteman @pdfjsbot @brendandahl @timvandermeij