XFA - Add support for reftests #13506
Conversation
There was a problem hiding this comment.
I've left a couple of comments, based on a quick first look; although I still haven't looked through the changes in test/driver.js in any detail.
Please note: This feels like the sort of changes where some context (in the commit message and/or PR description) would definitely have helped when going over the code.
For example: Given that you apparently needed to "hack" the API and FontLoader code to support XFA-testing, having explained why upfront would have saved me a little bit of time here.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.67.70.0:8877/bae7ab06a934679/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://3.101.106.178:8877/38c6c862cd221c0/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/bae7ab06a934679/output.txt Total script time: 4.76 mins
Image differences available at: http://54.67.70.0:8877/bae7ab06a934679/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/38c6c862cd221c0/output.txt Total script time: 5.14 mins
Image differences available at: http://3.101.106.178:8877/38c6c862cd221c0/reftest-analyzer.html#web=eq.log |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/ea8b9350ab47f1f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 2 Live output at: http://3.101.106.178:8877/1c0565456a399ea/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/ea8b9350ab47f1f/output.txt Total script time: 26.03 mins
Image differences available at: http://54.67.70.0:8877/ea8b9350ab47f1f/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/1c0565456a399ea/output.txt Total script time: 29.49 mins
Image differences available at: http://3.101.106.178:8877/1c0565456a399ea/reftest-analyzer.html#web=eq.log |
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/e2f6228cda4bf72/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/7c6c5d6a6ff22d7/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/e2f6228cda4bf72/output.txt Total script time: 22.82 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/7c6c5d6a6ff22d7/output.txt Total script time: 26.43 mins
|
In order to render correctly embedded fonts, we need hack the font loader to get font rules to inject them in the svg.
The idea is to pass a style element through the api to the font loader, load font rules in this element and finally get rules as string in the driver.