[api-minor] Fetch binary CMap data in the worker-thread, when useWorkerFetch is set
#13514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
base_factory
branch
from
7d69430
to
b18c050
Compare
Snuffleupagus
changed the title
useWorkerFetch is setuseWorkerFetch is set
…ontDataFactory` to their own file Given that these factories are being used in *different* files, for Browser respectively Node.js implementations, it seems reasonable to move them into their own file instead.
… set This patch uses the new option added in PR 12726 to *also* allow fetching binary CMap data directly in the worker-thread in browsers. Given that these changes remove the need to transfer data between threads for the default (browser) use-case, we can also revert the changes in PR 11118 since that simplifies the overall implementation.
Snuffleupagus
force-pushed
the
base_factory
branch
from
b18c050
to
d995f90
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/eba10bff5bb4366/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/65113f94ea0bd7f/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/eba10bff5bb4366/output.txt Total script time: 26.17 mins
Image differences available at: http://54.67.70.0:8877/eba10bff5bb4366/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/65113f94ea0bd7f/output.txt Total script time: 29.85 mins
Image differences available at: http://3.101.106.178:8877/65113f94ea0bd7f/reftest-analyzer.html#web=eq.log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch uses the new option added in PR #12726 to also allow fetching binary CMap data directly in the worker-thread in browsers.
Given that these changes remove the need to transfer data between threads for the default (browser) use-case, we can also revert the changes in PR #11118 since that simplifies the overall implementation.