Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XFA - Don't print arrow in select #13524

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Conversation

calixteman
Copy link
Contributor

No description provided.

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the comment addressed.

Comment on lines 302 to 303
-webkit-appearance: none;
-moz-appearance: none;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that just appearance: none; should suffice here, since Autoprefixer will take care of adding the prefixed versions as necessary.

Note e.g.

.annotationLayer .buttonWidgetAnnotation.radioButton input {
appearance: none;
which in the built file becomes

pdf.js/web/viewer.css

Lines 221 to 224 in 8a41c11

.annotationLayer .buttonWidgetAnnotation.radioButton input {
-webkit-appearance: none;
-moz-appearance: none;
appearance: none;

@calixteman calixteman merged commit 63bde1f into mozilla:master Jun 9, 2021
@timvandermeij timvandermeij removed the request for review from brendandahl June 9, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants