Add a DOMMatrix polyfill for Node.js environments (PR 13361 follow-up)
#13530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
DOMMatrix-Node
branch
from
d09e670
to
e5c2dbe
Compare
Snuffleupagus
commented
Jun 10, 2021
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/ababe85273871b7/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/fa9791958724a1d/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/ababe85273871b7/output.txt Total script time: 26.27 mins
Image differences available at: http://54.67.70.0:8877/ababe85273871b7/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/fa9791958724a1d/output.txt Total script time: 30.20 mins
Image differences available at: http://3.101.106.178:8877/fa9791958724a1d/reftest-analyzer.html#web=eq.log |
brendandahl
approved these changes
Jun 10, 2021
Given that `DOMMatrix` is, unsurprisingly, not supported in Node.js the `createMatrix` helper function in `src/display/pattern_helper.js` is most likely broken in Node.js environments. It will obviously try to fallback to the `DOMSVGFactory`, however that isn't intended for Node.js usage and errors will be thrown. Rather than trying to implement a `NodeSVGFactory`, this patch takes the easier route of just adding a `DOMMatrix` polyfill using: https://www.npmjs.com/package/dommatrix This isn't done only for simplicity, but it'll become necessary anyway since the `createMatrix` helper function is only temporary and will be removed in the future.
…ory` This is similar to all of the other factories in this file, since they *directly* throw errors.
Snuffleupagus
force-pushed
the
DOMMatrix-Node
branch
from
e5c2dbe
to
3bd24d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that
DOMMatrixis, unsurprisingly, not supported in Node.js thecreateMatrixhelper function insrc/display/pattern_helper.jsis most likely broken in Node.js environments. It will obviously try to fallback to theDOMSVGFactory, however that isn't intended for Node.js usage and errors will be thrown.Rather than trying to implement a
NodeSVGFactory, this patch takes easier route of just adding aDOMMatrixpolyfill using: https://www.npmjs.com/package/dommatrixThis isn't done only for simplicity, but it'll become necessary anyway since the
createMatrixhelper function is only temporary and will be removed in the future.