XFA - Return html element for the different possible value #13540
Conversation
calixteman
commented
Jun 11, 2021
calixteman
commented
- it aims to fix HSBC XFA "Compte" field not pre-filled #13536.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/32b79683c45d698/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://3.101.106.178:8877/915efcb4cc8224e/output.txt |
src/core/xfa/template.js
Outdated
| return HTMLResult.success({ | ||
| name: "span", | ||
| attributes: { | ||
| class: ["xfaRich"], | ||
| style: {}, | ||
| }, | ||
| value: this[$content] === 1, | ||
| }); |
There was a problem hiding this comment.
this code is all very similar between the different objects, what if you moved it to a base class and made all classes inherit this method?
or even just extract the code to an external function and call it in all places
src/core/xfa/template.js
Outdated
| @@ -4782,12 +4820,20 @@ class Time extends StringObject { | |||
| } | |||
|
|
|||
| [$finalize]() { | |||
| // TODO | |||
| this[$content] = new Date(this[$content]); | |||
| // TODO. | |||
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/32b79683c45d698/output.txt Total script time: 26.64 mins
Image differences available at: http://54.67.70.0:8877/32b79683c45d698/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/915efcb4cc8224e/output.txt Total script time: 30.18 mins
Image differences available at: http://3.101.106.178:8877/915efcb4cc8224e/reftest-analyzer.html#web=eq.log |
- it aims to fix mozilla#13536.
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/97a3c3b01fd9c9f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 1 Live output at: http://3.101.106.178:8877/0ae15ef555751e3/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/97a3c3b01fd9c9f/output.txt Total script time: 23.29 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/0ae15ef555751e3/output.txt Total script time: 27.31 mins
|
