XFA - Fix the way to select page on breaking

[calixteman]

• it aims to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1716838.
• some fonts in the pdf in the bug where bold when they shouldn't so write the font properties in the html to avoid to use some wrong inherited ones.

[brendandahl]

/botio test

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://3.101.106.178:8877/dcc9a9541efa5c7/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.67.70.0:8877/13916d3f7e321e9/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.67.70.0:8877/13916d3f7e321e9/output.txt

Total script time: 27.52 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: Passed
• Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/13916d3f7e321e9/reftest-analyzer.html#web=eq.log

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://3.101.106.178:8877/dcc9a9541efa5c7/output.txt

Total script time: 30.68 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: Passed
• Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/dcc9a9541efa5c7/reftest-analyzer.html#web=eq.log

[brendandahl]

Looks like there's regressions on imm1344e and imm1295e.

[calixteman]

/botio test

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/495b7b2cd53831c/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/0dadf19d021b896/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.67.70.0:8877/495b7b2cd53831c/output.txt

Total script time: 27.29 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: Passed
• Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/495b7b2cd53831c/reftest-analyzer.html#web=eq.log

[calixteman]

The diffs on imm1344e and imm1295e are expected: the first pageArea has a max set to 1 so the other pageArea must be used for other pages.

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://3.101.106.178:8877/0dadf19d021b896/output.txt

Total script time: 30.44 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: Passed
• Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/0dadf19d021b896/reftest-analyzer.html#web=eq.log

[marco-c]

The diffs on imm1344e and imm1295e are expected: the first pageArea has a max set to 1 so the other pageArea must be used for other pages.

In page 2 and 4 of imm1295e there seems to be a regression. The header and footer of page 2 and page 4 should be like on page 5.

Assuming imm1344e follows the same pattern as imm1295e, only the first page of the form should have "PROTECTED WHEN COMPLETED" in the header and "This form is made available ..." in the footer. This patch is fixing that for imm1344e, but partly regressing it for imm1295e.

[calixteman]

/botio test

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/c16f22d4d88a241/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/2a5b3462886bee3/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.67.70.0:8877/c16f22d4d88a241/output.txt

Total script time: 28.27 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: Passed
• Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/c16f22d4d88a241/reftest-analyzer.html#web=eq.log

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://3.101.106.178:8877/2a5b3462886bee3/output.txt

Total script time: 31.67 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: FAILED
• Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/2a5b3462886bee3/reftest-analyzer.html#web=eq.log

[calixteman]

There are some diff with xfa_bug1716816.pdf but it seems that this pdf is wrongly displayed (even before the patch).
I'll fix this pdf later.

[calixteman]

/botio makeref

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/350d04400471812/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_makeref from @calixteman received. Current queue size: 1

Live output at: http://3.101.106.178:8877/6ac8fa232b4b6d8/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.67.70.0:8877/350d04400471812/output.txt

Total script time: 24.71 mins

• Lint: Passed
• Make references: FAILED

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://3.101.106.178:8877/6ac8fa232b4b6d8/output.txt

Total script time: 29.48 mins

• Lint: Passed
• Make references: FAILED

[Snuffleupagus]

Sorry, but why was this landed with a bunch of breaking error (which is also why makeref failed) such as e.g. the following in multiple tests!?

TEST-UNEXPECTED-FAIL | test failed xfa_candidate_petitions | in chrome | page1 round 1 | Loading PDF document: UnknownErrorException: Cannot read property 'length' of undefined

This should probably be backed out, and then re-landed once fixed, to prevent testing being completely busted in the meantime!
(I'd suggest looking at not just the reference images, but also at the actual test output when e.g. reviewing :-P)

[calixteman]

(I'd suggest looking at not just the reference images, but also at the actual test output when e.g. reviewing :-P)

It's the reason why I missed the failures... sorry for that.

[Snuffleupagus]

Since it's currently way too easy to accidentally overlook breaking errors in the test-output, we might want to include more information directly in the botio output; in case it's deemed helpful, I've just submitted mozilla/botio-files-pdfjs#30

[marco-c]

Since it's currently way too easy to accidentally overlook breaking errors in the test-output, we might want to include more information directly in the botio output

Totally agree!