Set the default value of useSystemFonts correctly, depending on disableFontFace, in the API (PR 13516 follow-up)
#13587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sableFontFace`, in the API (PR 13516 follow-up) *Sorry about the churn here, since the change that I made in PR 13516 was not very smart.* With the current code, it's now *impossible* for a user to actually control the `useSystemFonts` option manually. To prevent outright breakage we obviously still need to default to setting `useSystemFonts = false` when `disableFontFace === true`, however that should be possible for an API consumer to override.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/7eb2b74b59dacf4/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/9bf92f3024c1d81/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/7eb2b74b59dacf4/output.txt Total script time: 27.15 mins
Image differences available at: http://54.67.70.0:8877/7eb2b74b59dacf4/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/9bf92f3024c1d81/output.txt Total script time: 30.06 mins
Image differences available at: http://3.101.106.178:8877/9bf92f3024c1d81/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
Jun 19, 2021
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry about the churn here, since the change that I made in PR #13516 was not very smart.
With the current code, it's now impossible for a user to actually control the
useSystemFontsoption manually. To prevent outright breakage we obviously still need to default to settinguseSystemFonts = falsewhendisableFontFace === true, however that should be possible for an API consumer to override.