Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly align the textLayer content with horizontal/spread scrolling modes (issue 13605) #13606

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Correctly align the textLayer content with horizontal/spread scrolling modes (issue 13605) #13606

merged 1 commit into from
Jun 22, 2021

Conversation

Snuffleupagus
Copy link
Collaborator

This is very similar to PR 12848, however for this textLayer-case it appears to only be an issue in documents with marked content.

@Snuffleupagus Snuffleupagus linked an issue Jun 21, 2021 that may be closed by this pull request
Improper text selection (selection position offset) during multi-page view (Odd or even spreads) #13605
Closed
@Snuffleupagus
Correctly align the textLayer content with horizontal/spread scroll…
daa563a 
…ing modes (issue 13605)

This is *very* similar to PR 12848, however for this `textLayer`-case it appears to only be an issue in documents with marked content.
@Snuffleupagus Snuffleupagus changed the title Correctly align the textLayer content with horizontal/spead scrolling modes (issue 13605) Correctly align the textLayer content with horizontal/spread scrolling modes (issue 13605) Jun 21, 2021
@mozilla mozilla deleted a comment from pdfjsbot Jun 22, 2021
@mozilla mozilla deleted a comment from pdfjsbot Jun 22, 2021
@mozilla mozilla deleted a comment from pdfjsbot Jun 22, 2021
@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://3.101.106.178:8877/8b9310c6eb9084d/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/227289ee35ee784/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/227289ee35ee784/output.txt

Total script time: 28.43 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 9

Image differences available at: http://54.67.70.0:8877/227289ee35ee784/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/8b9310c6eb9084d/output.txt

Total script time: 32.30 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 7
  different first/second rendering: 2

Image differences available at: http://3.101.106.178:8877/8b9310c6eb9084d/reftest-analyzer.html#web=eq.log

@Snuffleupagus Snuffleupagus mentioned this pull request Jun 22, 2021
Merged
@Snuffleupagus
Copy link
Collaborator Author

Snuffleupagus commented Jun 22, 2021 •
edited
Loading

@calixteman r=?
This is basically identical to PR #13609, which you reviewed, but for the textLayer instead; please see #13605 for STR.

@Snuffleupagus Snuffleupagus merged commit 9441245 into mozilla:master Jun 22, 2021
@Snuffleupagus Snuffleupagus deleted the issue-13605 branch June 22, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
text-selection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improper text selection (selection position offset) during multi-page view (Odd or even spreads)
3 participants
@Snuffleupagus @pdfjsbot @calixteman