Reset the IPDFLinkService.externalLinkEnabled property on document closing
#13617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…closing Given that this property is only used with password protected documents, and is consequently document-specific rather than viewer-specific, ensure that `IPDFLinkService.externalLinkEnabled` is actually being reset by `PDFViewerApplication.close`. To make things less confusing/inconsistent, remove the *undocumented* `externalLinkEnabled` property from the `PDFLinkService` constructor and force it to always be manually set when needed.
Snuffleupagus
force-pushed
the
reset-externalLinkEnabled
branch
from
f5d1a2b
to
d959cb8
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/26e26746b80a60f/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/26e26746b80a60f/output.txt Total script time: 4.53 mins Published |
timvandermeij
approved these changes
Jun 23, 2021
|
Looks good; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that this property is only used with password protected documents, and is consequently document-specific rather than viewer-specific, ensure that
IPDFLinkService.externalLinkEnabledis actually being reset byPDFViewerApplication.close.To make things less confusing/inconsistent, remove the undocumented
externalLinkEnabledproperty from thePDFLinkServiceconstructor and force it to always be manually set when needed.