XFA - Implement aspect property on image element #13641
Conversation
calixteman
commented
Jun 27, 2021
calixteman
commented
- it aims to fix issue Image not scaled proportionality #13634;
- move some img-related functions in test/drivers.js in order to have images in xfa reftests.
|
A lot of xfa contains image so a lot of failure in reftests are expected. /botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/aba411c362a809d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://3.101.106.178:8877/529d545b25aa011/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/aba411c362a809d/output.txt Total script time: 28.77 mins
Image differences available at: http://54.67.70.0:8877/aba411c362a809d/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/529d545b25aa011/output.txt Total script time: 32.77 mins
Image differences available at: http://3.101.106.178:8877/529d545b25aa011/reftest-analyzer.html#web=eq.log |
| return loadedPromises; | ||
| }); | ||
|
|
||
| await resolveImages(div); |
There was a problem hiding this comment.
await resolveImages(div) is a list of promises, shouldn't you await them via await Promise.all(await resolveImages(div))?
There was a problem hiding this comment.
Or, you could add await Promise.all(loadedPromises) at the end of resolveImages and keep the code here as it is.
There was a problem hiding this comment.
The second suggestion is definitely the preferred way of doing things here!
Given that this patch moves pre-existing code, it's actually quite interesting that this old issue this hasn't caused any bugs (as far as we know).
There was a problem hiding this comment.
I locally got some errors because tiff images are not rendered by neither firefox nor chrome which is expected.
So I disabled promise rejection for image failures for the xfa reftests.
- it aims to fix issue mozilla#13634; - move some img-related functions in test/drivers.js in order to have images in xfa reftests.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/769fa4dc9cd8c2b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 1 Live output at: http://3.101.106.178:8877/8d6bc475d8187f7/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/769fa4dc9cd8c2b/output.txt Total script time: 29.29 mins
Image differences available at: http://54.67.70.0:8877/769fa4dc9cd8c2b/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/8d6bc475d8187f7/output.txt Total script time: 33.63 mins
Image differences available at: http://3.101.106.178:8877/8d6bc475d8187f7/reftest-analyzer.html#web=eq.log |
|
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://3.101.106.178:8877/69b849161f9bb68/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/e7b9affd8aa5b05/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/e7b9affd8aa5b05/output.txt Total script time: 26.02 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/69b849161f9bb68/output.txt Total script time: 31.16 mins
|
