Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XFA - Remove quotes of font name in xhtml #13642

Merged
merged 1 commit into from
Jun 28, 2021
Merged

XFA - Remove quotes of font name in xhtml #13642

merged 1 commit into from
Jun 28, 2021

Conversation

calixteman
Copy link
Contributor

Fix for font issue in #13631.

Snuffleupagus
Snuffleupagus approved these changes Jun 28, 2021
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing tests; thanks!

@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/947a4366a2d3d2b/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/7f5a99f35d0d3b9/output.txt

@marco-c marco-c linked an issue Jun 28, 2021 that may be closed by this pull request
XFA Form missing some text content #13631
Closed
@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/947a4366a2d3d2b/output.txt

Total script time: 28.76 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 8
  different first/second rendering: 1

Image differences available at: http://54.67.70.0:8877/947a4366a2d3d2b/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/7f5a99f35d0d3b9/output.txt

Total script time: 32.70 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 8
  different first/second rendering: 1

Image differences available at: http://3.101.106.178:8877/7f5a99f35d0d3b9/reftest-analyzer.html#web=eq.log

@calixteman calixteman merged commit 191db41 into mozilla:master Jun 28, 2021
@calixteman
Copy link
Contributor Author

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/0dadef1c7fcc57d/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 1

Live output at: http://3.101.106.178:8877/f8c679cc8750060/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/0dadef1c7fcc57d/output.txt

Total script time: 25.38 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)

Success

Full output at http://3.101.106.178:8877/f8c679cc8750060/output.txt

Total script time: 29.93 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@calixteman calixteman deleted the quotes branch June 28, 2021 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
form-xfa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XFA Form missing some text content
4 participants
@calixteman @pdfjsbot @Snuffleupagus @marco-c