Don't attempt to structure clone unsupported types with workers disabled #13658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please refer to https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API/Structured_clone_algorithm Based on that information, and manually testing our code, the implementation in `cloneValue` has the following shortcomings: - Attempting to clone `function`s is only prevented when they're part of an Object, but is currently allowed when they occur standalone. - Cloning of `Symbol`s is currently not prevented, which it should be since the native structured clone algorithm throws. - Any disallowed types should be checked first, to reduce the risk of future changes accidentally allowing something that shouldn't be supported.
|
Given that only the Node.js tests, as run by e.g. GitHub Actions, actually trigger these code-paths running the full test-suite seem mostly like a waste of time. /botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 1 Live output at: http://3.101.106.178:8877/b51ce2ae3362df7/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.67.70.0:8877/b68cb40d28e6fb3/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/b68cb40d28e6fb3/output.txt Total script time: 3.95 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/b51ce2ae3362df7/output.txt Total script time: 5.42 mins
|
timvandermeij
approved these changes
Jul 3, 2021
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API/Structured_clone_algorithm
Based on that information, and manually testing our code, the implementation in
cloneValuehas the following shortcomings:functions is only prevented when they're part of an Object, but is currently allowed when they occur standalone.Symbols is currently not prevented, which it should be since the native structured clone algorithm throws.