Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XFA - Don't use system font when a font is not embeded but there is a substitution #13662

Merged
merged 1 commit into from
Jul 4, 2021

Conversation

calixteman
Copy link
Contributor

  • always use a font coming from pdf.js when there is one: this way we don't use a system font which could looks wrong.

… substitution

  - always use a font coming from pdf.js when there is one: this way we don't use a system font which could looks wrong.
@calixteman
Copy link
Contributor Author

The problem is visible on the screenshot in issue #13633: space between glyphes is a bit strange (see the space after "k" in "bekannt").
I can reproduce locally (and it's worst on my windows ws) and with this patch the pdf in the above issue looks a way better.

@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Jul 3, 2021

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/0d701b5690d878f/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 3, 2021

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/b3df406cadd2d83/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 3, 2021

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/0d701b5690d878f/output.txt

Total script time: 30.34 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 13
  different first/second rendering: 1

Image differences available at: http://54.67.70.0:8877/0d701b5690d878f/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Jul 3, 2021

From: Bot.io (Windows)


Failed

Full output at http://3.101.106.178:8877/b3df406cadd2d83/output.txt

Total script time: 34.73 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 46
  different first/second rendering: 1

Image differences available at: http://3.101.106.178:8877/b3df406cadd2d83/reftest-analyzer.html#web=eq.log

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good improvement overall, thank you!

@Snuffleupagus Snuffleupagus merged commit de80590 into mozilla:master Jul 4, 2021
@Snuffleupagus
Copy link
Collaborator

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Jul 4, 2021

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/b776a7267bf0b34/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 4, 2021

From: Bot.io (Windows)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://3.101.106.178:8877/27eed58b0af0ebb/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 4, 2021

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/b776a7267bf0b34/output.txt

Total script time: 27.06 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Jul 4, 2021

From: Bot.io (Windows)


Success

Full output at http://3.101.106.178:8877/27eed58b0af0ebb/output.txt

Total script time: 31.78 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants