Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the ESLint operator-assignment rule #13666

Merged

Conversation

Snuffleupagus
Copy link
Collaborator

  • Enable the ESLint operator-assignment rule

    This patch was generated automatically, using the gulp lint --fix command.

    Please find additional details about the ESLint rule at https://eslint.org/docs/rules/operator-assignment

  • Fix the remaining ESLint operator-assignment errors

This patch was generated automatically, using the `gulp lint --fix` command.

Please find additional details about the ESLint rule at https://eslint.org/docs/rules/operator-assignment
@Snuffleupagus
Copy link
Collaborator Author

/botio lint

@pdfjsbot
Copy link

pdfjsbot commented Jul 4, 2021

From: Bot.io (Linux m4)


Received

Command cmd_lint from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/85c3b6d8ca98bf5/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 4, 2021

From: Bot.io (Windows)


Received

Command cmd_lint from @Snuffleupagus received. Current queue size: 0

Live output at: http://3.101.106.178:8877/08fff9897d8ab76/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 4, 2021

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/85c3b6d8ca98bf5/output.txt

Total script time: 2.47 mins

  • Lint: Passed

@pdfjsbot
Copy link

pdfjsbot commented Jul 4, 2021

From: Bot.io (Windows)


Success

Full output at http://3.101.106.178:8877/08fff9897d8ab76/output.txt

Total script time: 4.78 mins

  • Lint: Passed

@Snuffleupagus Snuffleupagus force-pushed the eslint-operator-assignment branch 3 times, most recently from 4806e35 to 9a69356 Compare July 4, 2021 13:23
@pdfjsbot
Copy link

pdfjsbot commented Jul 4, 2021

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/66541dc0012da4f/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 4, 2021

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://3.101.106.178:8877/ba72b8f0b3ff0ef/output.txt

@mozilla mozilla deleted a comment from pdfjsbot Jul 4, 2021
@mozilla mozilla deleted a comment from pdfjsbot Jul 4, 2021
@mozilla mozilla deleted a comment from pdfjsbot Jul 4, 2021
@mozilla mozilla deleted a comment from pdfjsbot Jul 4, 2021
@pdfjsbot
Copy link

pdfjsbot commented Jul 4, 2021

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/66541dc0012da4f/output.txt

Total script time: 30.24 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 9
  different first/second rendering: 3

Image differences available at: http://54.67.70.0:8877/66541dc0012da4f/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Jul 4, 2021

From: Bot.io (Windows)


Failed

Full output at http://3.101.106.178:8877/ba72b8f0b3ff0ef/output.txt

Total script time: 34.24 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 7
  different first/second rendering: 1

Image differences available at: http://3.101.106.178:8877/ba72b8f0b3ff0ef/reftest-analyzer.html#web=eq.log

@timvandermeij timvandermeij merged commit 62808cb into mozilla:master Jul 4, 2021
@timvandermeij
Copy link
Contributor

Thank you!

@Snuffleupagus Snuffleupagus deleted the eslint-operator-assignment branch July 18, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants