Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XFA - Avoid to have containers not pushed in the html #13721

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

calixteman
Copy link
Contributor

@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/d48e14b8a27386b/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/4f707d9f7cf8187/output.txt

@Snuffleupagus Snuffleupagus linked an issue Jul 12, 2021 that may be closed by this pull request
@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/d48e14b8a27386b/output.txt

Total script time: 32.26 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 26
  different first/second rendering: 1

Image differences available at: http://54.67.70.0:8877/d48e14b8a27386b/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://3.101.106.178:8877/4f707d9f7cf8187/output.txt

Total script time: 36.85 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 27
  different first/second rendering: 3

Image differences available at: http://3.101.106.178:8877/4f707d9f7cf8187/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Jul 12, 2021

Compared with Adobe Reader, the issue13611 test-case seems to regress a little bit (w.r.t. the placement of page breaks).

@calixteman
Copy link
Contributor Author

The issue fixed by this patch is a way worse than the regression.
So if you're ok, we can merge this PR and then we could update the m-c version (once https://bugzilla.mozilla.org/show_bug.cgi?id=1720159 is fixed too) and I'll fix the regression in a follow-up.
@marco-c, are you ok ?

@calixteman
Copy link
Contributor Author

Finally the fix was pretty easy.

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/fdfe87ac7770abb/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/248e41f5e4811b9/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://3.101.106.178:8877/248e41f5e4811b9/output.txt

Total script time: 31.46 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  errors: 603
  different ref/snapshot: 11
  different first/second rendering: 1

Image differences available at: http://3.101.106.178:8877/248e41f5e4811b9/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/fdfe87ac7770abb/output.txt

Total script time: 32.43 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 12

Image differences available at: http://54.67.70.0:8877/fdfe87ac7770abb/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

/botio-windows test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/4c0ca1e1e24ed47/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://3.101.106.178:8877/4c0ca1e1e24ed47/output.txt

Total script time: 37.64 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 10
  different first/second rendering: 1

Image differences available at: http://3.101.106.178:8877/4c0ca1e1e24ed47/reftest-analyzer.html#web=eq.log

@calixteman calixteman merged commit a17bd13 into mozilla:master Jul 13, 2021
@calixteman
Copy link
Contributor Author

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/b6f437754b67abd/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/9b9c3c06a4c27d6/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/b6f437754b67abd/output.txt

Total script time: 29.18 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://3.101.106.178:8877/9b9c3c06a4c27d6/output.txt

Total script time: 34.23 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Large amount of text missing
4 participants