Ensure that the field value, for checkboxes, refers to an existing appearance state (bug 1720411)

[Snuffleupagus]

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1720411

[marco-c]

@Snuffleupagus do you know what caused the regression?

[Snuffleupagus]

do you know what caused the regression?

Are we sure that this actually is a regression, since there wasn't an exact regression range provided in the bug (and I've not had time to actually bisect it)?

However, assuming that it's a regression, a potential candidate would be PR #13274 since the changes in https://github.com/mozilla/pdf.js/pull/13274/files#diff-d7b040092cf6be09a276b785ba03c46e79bc8342cf4ae4fb1bc139dea8513425R931-R935 are unlikely to work all that well with broken/corrupt PDF documents that contain empty Name-instances.

I suppose that we could also have added a work-around on the main-thread, however it seems to me that trying to reference a non-existent appearance state isn't generally correct; at least that's how I'm reading the PDF specification:

The V entry in the field dictionary (see Table 220) holds a name object representing the check box’s appearance state, which shall be used to select the appropriate appearance from the appearance dictionary.

[marco-c]

All right, I'm running mozregression to double check!

[marco-c]

https://bugzilla.mozilla.org/show_bug.cgi?id=1711106 is the cause, so I guess it's #13274 like you suggested.

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/1eed811855ee271/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://3.101.106.178:8877/e18b13ca43b3a9b/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.67.70.0:8877/1eed811855ee271/output.txt

Total script time: 32.30 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: Passed
• Regression tests: FAILED

  different ref/snapshot: 12
  different first/second rendering: 1

Image differences available at: http://54.67.70.0:8877/1eed811855ee271/reftest-analyzer.html#web=eq.log

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://3.101.106.178:8877/e18b13ca43b3a9b/output.txt

Total script time: 38.06 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: FAILED
• Regression tests: FAILED

  different ref/snapshot: 5
  different first/second rendering: 1

Image differences available at: http://3.101.106.178:8877/e18b13ca43b3a9b/reftest-analyzer.html#web=eq.log

[timvandermeij]

/botio-linux preview

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/e307ca86890d83f/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.67.70.0:8877/e307ca86890d83f/output.txt

Total script time: 5.29 mins

Published

• Viewer: http://54.67.70.0:8877/e307ca86890d83f/web/viewer.html
• Viewer (legacy): http://54.67.70.0:8877/e307ca86890d83f/legacy/web/viewer.html

[timvandermeij]

Thank you for fixing this!

/botio makeref

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/9284e253767b953/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_makeref from @timvandermeij received. Current queue size: 1

Live output at: http://3.101.106.178:8877/2834d5a8c796282/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.67.70.0:8877/9284e253767b953/output.txt

Total script time: 29.32 mins

• Lint: Passed
• Make references: Passed
• Check references: Passed

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://3.101.106.178:8877/2834d5a8c796282/output.txt

Total script time: 34.60 mins

• Lint: Passed
• Make references: Passed
• Check references: Passed