Remove the IR (internal representation) part of the PDFFunction parsing
#13754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing *This follows the exact same princial as PR 12083, but for the `PDFFunction` parsing instead.* Given that the IR format is completely unused now, all that the current code does is add a bunch of unnecessary indirection/overhead to the handling of PDF-functions.
For e.g. `gulp mozcentral`, the *built* `pdf.worker.js` file decreases from `1 837 608` to `1 834 907` bytes with this patch-series. The improvement comes first of all from less overall indentation in `PDFFunction`, and secondly from the removal of (now) unnecessary indirection in the code.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/a231c8766f327d3/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/5e74bb335ca11a7/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/a231c8766f327d3/output.txt Total script time: 32.42 mins
Image differences available at: http://54.67.70.0:8877/a231c8766f327d3/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/5e74bb335ca11a7/output.txt Total script time: 37.48 mins
Image differences available at: http://3.101.106.178:8877/5e74bb335ca11a7/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
Jul 18, 2021
|
Much simpler; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the IR (internal representation) part of the
PDFFunctionparsingThis follows the exact same princial as PR Remove the IR (internal representation) part of the ColorSpace parsing #12083, but for the
PDFFunctionparsing instead.Given that the IR format is completely unused now, all that the current code does is add a bunch of unnecessary indirection/overhead to the handling of PDF-functions.
Convert
PDFFunctionto a standard class withstaticmethodsFor e.g.
gulp mozcentral, the builtpdf.worker.jsfile decreases from1 837 608to1 834 907bytes with this patch-series.The improvement comes first of all from less overall indentation in
PDFFunction, and secondly from the removal of (now) unnecessary indirection in the code.