XFA - Add a missing method to XFAAttribute, to prevent breaking errors (issue 13748)
#13764
Conversation
…ors (issue 13748) *This is yet another case where I've got no idea if the patch is correct, but it does at least fix a breaking error :-)* Note how in the [`Binder._bindValue` method](https://github.com/mozilla/pdf.js/blob/683ce66a48cd54fa48e96e1925277c134859e76c/src/core/xfa/bind.js#L92-L93), we're assuming that if a `data`-value exists then it'll also be possible to actually access it. For the `XFAAttribute`-implementation however, the second method is missing and that's what causes the breaking errors in issue 13748. Please note that another possible way of "fixing" the error wouldn't been to simply change the exists-check to return `false`, and I could see that being a preferred solution. However, the reason for submitting the current patch is that we get *fewer* warnings about Nodes with mis-matched types this way.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/fc12f112f4f5593/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/effed94698e133b/output.txt |
|
Is this fixing #13748 completely? |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/fc12f112f4f5593/output.txt Total script time: 32.58 mins
Image differences available at: http://54.67.70.0:8877/fc12f112f4f5593/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/effed94698e133b/output.txt Total script time: 38.51 mins
Image differences available at: http://3.101.106.178:8877/effed94698e133b/reftest-analyzer.html#web=eq.log |
Unfortunately not, since there's a bunch of scripting in that document as well (I've updated the tags accordingly). |
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/531c126f24507ef/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 1 Live output at: http://3.101.106.178:8877/56dec221892879e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/531c126f24507ef/output.txt Total script time: 29.26 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/56dec221892879e/output.txt Total script time: 35.85 mins
|
This is yet another case where I've got no idea if the patch is correct, but it does at least fix a breaking error :-)
Note how in the
Binder._bindValuemethod, we're assuming that if adata-value exists then it'll also be possible to actually access it. For theXFAAttribute-implementation however, the second method is missing and that's what causes the breaking errors in issue #13748.Please note that another possible way of "fixing" the error wouldn't been to simply change the exists-check to return
false, and I could see that being a preferred solution.However, the reason for submitting the current patch is that we get fewer warnings about Nodes with mis-matched types this way.