XFA - Handle startIndex correctly in the Template.$toHTML method (issue 13751)
#13766
Conversation
Snuffleupagus
force-pushed
the
issue-13751
branch
from
a1bcf05
to
49964f1
Compare
…(issue 13751) *Please note:* The PDF document in issue 13751 is *dynamically* created (in e.g. Adobe Reader), with pages added when certain buttons are clicked, hence this patch simply fixes the breaking error and nothing more. It looks like the current code contains a little bit too much copy-and-paste from the *similar* `index` branch above, since we cannot set the `startIndex` to a negative value. Note how it's being used to initialize the loop-variable, which is then used to lookup values in an Array and accessing the `-1`th element of an Array obviously makes no sense.
Snuffleupagus
force-pushed
the
issue-13751
branch
from
49964f1
to
7d1c19f
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/fe662f04a0f9aec/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/f1d0be02357704f/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/fe662f04a0f9aec/output.txt Total script time: 27.07 mins
Image differences available at: http://54.67.70.0:8877/fe662f04a0f9aec/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/f1d0be02357704f/output.txt Total script time: 37.88 mins
Image differences available at: http://3.101.106.178:8877/f1d0be02357704f/reftest-analyzer.html#web=eq.log |
|
/botio-linux browsertest |
From: Bot.io (Linux m4)InvalidCommand not implemented: |
|
/botio-linux test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.67.70.0:8877/0e101b37b04eb1e/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/0e101b37b04eb1e/output.txt Total script time: 25.53 mins
Image differences available at: http://54.67.70.0:8877/0e101b37b04eb1e/reftest-analyzer.html#web=eq.log |
|
/botio-linux test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/12f4acd9db904ef/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/12f4acd9db904ef/output.txt Total script time: 32.56 mins
Image differences available at: http://54.67.70.0:8877/12f4acd9db904ef/reftest-analyzer.html#web=eq.log |
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.67.70.0:8877/704ae696f786917/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 3 Live output at: http://3.101.106.178:8877/7fb5c2a31057987/output.txt |
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/7fb5c2a31057987/output.txt Total script time: 34.97 mins
|
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/704ae696f786917/output.txt Total script time: 29.38 mins
|
Please note: The PDF document in issue #13751 is dynamically created (in e.g. Adobe Reader), with pages added when certain buttons are clicked, hence this patch simply fixes the breaking error and nothing more.
It looks like the current code contains a little bit too much copy-and-paste from the similar
indexbranch above, since we cannot set thestartIndexto a negative value. Note how it's being used to initialize the loop-variable, which is then used to lookup values in an Array and accessing the-1th element of an Array obviously makes no sense.