Move the compatibilityParams into the web/app_options.js file
#13804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that we've over time been reducing the number of `compatibilityParams` in use, there's now few enough left that I think it makes sense to simply inline them directly in the `web/app_options.js` file. Note that we recently inlined/removed the separate `src/display/api_compatibility.js` file, see PR 13525, and that it (in my opinion) thus makes sense to do the same in the `web/`-folder. This patch will also slightly reduce the size of *built* `web/viewer.js` file, which cannot hurt.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/70813f9b3d266d6/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/70813f9b3d266d6/output.txt Total script time: 4.92 mins Published |
timvandermeij
approved these changes
Jul 27, 2021
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that we've over time been reducing the number of
compatibilityParamsin use, there's now few enough left that I think it makes sense to simply inline them directly in theweb/app_options.jsfile.Note that we recently inlined/removed the separate
src/display/api_compatibility.jsfile, see PR #13525, and that it (in my opinion) thus makes sense to do the same in theweb/-folder. This patch will also slightly reduce the size of builtweb/viewer.jsfile, which cannot hurt.