Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XFA - Fix font scale factors (bug 1720888) #13815

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

calixteman
Copy link
Contributor

  • All the scale factors in for the substitution font were wrong because of different glyph positions between Liberation and the other ones:
    • regenerate all the factors
  • Text may have polish chars for example and in this case the glyph widths were wrong:
    • treat substitution font as a composite one
    • add a map glyphIndex to unicode for Liberation in order to generate width array for cid font

@calixteman
Copy link
Contributor Author

I always suspected that something was wrong with glyphs widths for substitution font because of scale factors (the rendering always annoyed me) and this patch will fix that, it means a lot of regression on text rendering but overall it's better.

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/e64b2823ac22c89/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/a286551d8166456/output.txt

  - All the scale factors in for the substitution font were wrong because of different glyph positions between Liberation and the other ones:
    - regenerate all the factors
  - Text may have polish chars for example and in this case the glyph widths were wrong:
    - treat substitution font as a composite one
    - add a map glyphIndex to unicode for Liberation in order to generate width array for cid font
@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/e64b2823ac22c89/output.txt

Total script time: 33.30 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 234
  different first/second rendering: 3

Image differences available at: http://54.67.70.0:8877/e64b2823ac22c89/reftest-analyzer.html#web=eq.log

Copy link
Contributor

@marco-c marco-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can only see improvements or minor changes in the reftests.

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://3.101.106.178:8877/a286551d8166456/output.txt

Total script time: 39.42 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 516
  different first/second rendering: 1

Image differences available at: http://3.101.106.178:8877/a286551d8166456/reftest-analyzer.html#web=eq.log

@calixteman calixteman merged commit edbe969 into mozilla:master Jul 28, 2021
@calixteman
Copy link
Contributor Author

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @calixteman received. Current queue size: 1

Live output at: http://54.67.70.0:8877/b0ab4dd82ee2ec6/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @calixteman received. Current queue size: 2

Live output at: http://3.101.106.178:8877/29734ff4f8953c2/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/b0ab4dd82ee2ec6/output.txt

Total script time: 30.37 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://3.101.106.178:8877/29734ff4f8953c2/output.txt

Total script time: 29.05 mins

  • Lint: Passed
  • Make references: FAILED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants