Annotation & XFA: Scale the font size in choicelist using zoom factor (bug 1715996) #13868

calixteman · 2021-08-04T12:46:59Z

this is an accessibility issue which could be painful for some people with visual disabilities.

src/core/xfa/template.js

Snuffleupagus · 2021-08-04T13:13:38Z

web/base_viewer.js

@@ -694,6 +694,8 @@ class BaseViewer {
  }

  _setScaleUpdatePages(newScale, newValue, noScroll = false, preset = false) {
+    document.documentElement.style.setProperty("--zoom-factor", newScale);


First of all, please move this down to just after the if (isSameScale(...)) { ... } block below, since there's no good reason to update this unconditionally as far as I can tell.

Secondly, let's add this._doc = document.documentElement; after e.g.

pdf.js/web/base_viewer.js

Line 204 in 52ef63f

}

and utilize that instead there.

Also, this won't work when PDFPageView is being used standalone. Ideally we should probably move this code into PDFPageView.update instead, but I'm not sure if repeatedly setting the CSS variable (to the same value) is an issue performance-wise?
However, I'd be OK with deferring this point for now in the interest of getting it fixed in a timely manner.

Snuffleupagus · 2021-08-04T13:15:02Z

web/viewer.css

@@ -16,6 +16,8 @@
 @import url(pdf_viewer.css);

 :root {
+  --zoom-factor: 1;


This needs to be placed in pdf_viewer.css instead, since otherwise you're breaking the standalone viewer components.

Snuffleupagus · 2021-08-04T13:49:49Z

/botio test

pdfjsbot · 2021-08-04T13:49:50Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/afddeed44d80c81/output.txt

pdfjsbot · 2021-08-04T13:49:50Z

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://3.101.106.178:8877/e126d74dc1b3bb4/output.txt

pdfjsbot · 2021-08-04T14:23:03Z

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/e126d74dc1b3bb4/output.txt

Total script time: 33.20 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  errors: 612
  different ref/snapshot: 9
  different first/second rendering: 2

Image differences available at: http://3.101.106.178:8877/e126d74dc1b3bb4/reftest-analyzer.html#web=eq.log

pdfjsbot · 2021-08-04T14:24:42Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/afddeed44d80c81/output.txt

Total script time: 34.85 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 8
  different first/second rendering: 2

Image differences available at: http://54.67.70.0:8877/afddeed44d80c81/reftest-analyzer.html#web=eq.log

Snuffleupagus · 2021-08-04T14:27:51Z

There seem to be one regression in chrome-annotation-choice-widget-forms-page1.

calixteman · 2021-08-04T14:37:28Z

Yep, I forgot to set the font size only for combo choicelist.

calixteman · 2021-08-04T14:38:16Z

/botio test

pdfjsbot · 2021-08-04T14:38:17Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/9769fd7e81c6223/output.txt

pdfjsbot · 2021-08-04T14:38:17Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/a011d5bca46d56a/output.txt

pdfjsbot · 2021-08-04T15:13:04Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/9769fd7e81c6223/output.txt

Total script time: 34.77 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 13
  different first/second rendering: 1

Image differences available at: http://54.67.70.0:8877/9769fd7e81c6223/reftest-analyzer.html#web=eq.log

Snuffleupagus · 2021-08-04T15:14:51Z

Yep, I forgot to set the font size only for combo choicelist.

It looks like you forgot to push the changes?

Also, a couple of the integrationtests fail on all platforms/browsers, so those tests may need some updates as well?

pdfjsbot · 2021-08-04T15:18:16Z

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/a011d5bca46d56a/output.txt

Total script time: 39.96 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 8
  different first/second rendering: 1

Image differences available at: http://3.101.106.178:8877/a011d5bca46d56a/reftest-analyzer.html#web=eq.log

calixteman · 2021-08-04T15:35:35Z

/botio test

pdfjsbot · 2021-08-04T15:35:36Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/0bcf82be5692316/output.txt

pdfjsbot · 2021-08-04T15:35:37Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/e1f5eb540e1a61a/output.txt

pdfjsbot · 2021-08-04T16:01:45Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/0bcf82be5692316/output.txt

Total script time: 26.13 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  errors: 639
  different ref/snapshot: 7
  different first/second rendering: 2

Image differences available at: http://54.67.70.0:8877/0bcf82be5692316/reftest-analyzer.html#web=eq.log

calixteman · 2021-08-04T16:12:56Z

/botio-linux test

pdfjsbot · 2021-08-04T16:12:57Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/2161bac77c3f2f8/output.txt

pdfjsbot · 2021-08-04T16:14:32Z

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/e1f5eb540e1a61a/output.txt

Total script time: 38.91 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 7
  different first/second rendering: 1

Image differences available at: http://3.101.106.178:8877/e1f5eb540e1a61a/reftest-analyzer.html#web=eq.log

pdfjsbot · 2021-08-04T16:46:25Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/2161bac77c3f2f8/output.txt

Total script time: 33.46 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 10
  different first/second rendering: 2

Image differences available at: http://54.67.70.0:8877/2161bac77c3f2f8/reftest-analyzer.html#web=eq.log

calixteman · 2021-08-04T16:47:19Z

/botio-linux preview

pdfjsbot · 2021-08-04T16:47:21Z

From: Bot.io (Linux m4)

Received

Command cmd_preview from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/94f1f691698295b/output.txt

pdfjsbot · 2021-08-04T16:52:30Z

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/94f1f691698295b/output.txt

Total script time: 5.14 mins

Published

Viewer: http://54.67.70.0:8877/94f1f691698295b/web/viewer.html
Viewer (legacy): http://54.67.70.0:8877/94f1f691698295b/legacy/web/viewer.html

Snuffleupagus · 2021-08-04T18:01:24Z

Testing the preview, with the annotation-choice-widget.pdf file from the test-suite, there's now a large of amount of "padding" in the dropdowns (i.e. similar to the previously failing ref-tests above); please see the following screen-shot:

… (bug 1715996) - this is an accessibility issue which could be painful for some people with visual disabilities.

calixteman · 2021-08-04T18:38:49Z

/botio test

pdfjsbot · 2021-08-04T18:38:50Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/e17dd845fc3c2c1/output.txt

pdfjsbot · 2021-08-04T18:38:51Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://3.101.106.178:8877/14537e4295eec8b/output.txt

calixteman · 2021-08-04T18:42:57Z

Testing the preview, with the annotation-choice-widget.pdf file from the test-suite, there's now a large of amount of "padding" in the dropdowns (i.e. similar to the previously failing ref-tests above); please see the following screen-shot:

I thought adding font-size stuff on an optgroup will help to reduce the number of setProperty but I misunderstood what optgroup is and it's why some extra blanks were added at the beginning of the line.
So finally, I added font-size stuff on each option, if you've a good idea to avoid that, please propose.

pdfjsbot · 2021-08-04T19:05:04Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/e17dd845fc3c2c1/output.txt

Total script time: 26.23 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  errors: 639
  different ref/snapshot: 11
  different first/second rendering: 1

Image differences available at: http://54.67.70.0:8877/e17dd845fc3c2c1/reftest-analyzer.html#web=eq.log

pdfjsbot · 2021-08-04T19:15:43Z

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/14537e4295eec8b/output.txt

Total script time: 32.46 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  errors: 612
  different ref/snapshot: 12
  different first/second rendering: 1

Image differences available at: http://3.101.106.178:8877/14537e4295eec8b/reftest-analyzer.html#web=eq.log

calixteman · 2021-08-04T19:30:12Z

/botio test

pdfjsbot · 2021-08-04T19:30:13Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/b4d0638614dda26/output.txt

pdfjsbot · 2021-08-04T19:30:14Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/0a89046e18bda03/output.txt

pdfjsbot · 2021-08-04T20:03:44Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/0a89046e18bda03/output.txt

Total script time: 33.49 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 16
  different first/second rendering: 1

Image differences available at: http://54.67.70.0:8877/0a89046e18bda03/reftest-analyzer.html#web=eq.log

pdfjsbot · 2021-08-04T20:09:21Z

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/b4d0638614dda26/output.txt

Total script time: 39.11 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 11
  different first/second rendering: 1

Image differences available at: http://3.101.106.178:8877/b4d0638614dda26/reftest-analyzer.html#web=eq.log

calixteman · 2021-08-04T20:10:58Z

The differences are due to the fact we use the fontsize from the pdf.

calixteman · 2021-08-04T20:11:09Z

/botio-linux preview

pdfjsbot · 2021-08-04T20:11:10Z

From: Bot.io (Linux m4)

Received

Command cmd_preview from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/00bcf1864098081/output.txt

pdfjsbot · 2021-08-04T20:16:18Z

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/00bcf1864098081/output.txt

Total script time: 5.13 mins

Published

Viewer: http://54.67.70.0:8877/00bcf1864098081/web/viewer.html
Viewer (legacy): http://54.67.70.0:8877/00bcf1864098081/legacy/web/viewer.html

Snuffleupagus · 2021-08-05T08:44:52Z

So finally, I added font-size stuff on each option, if you've a good idea to avoid that, please propose.

Given that documents likely won't contain more than perhaps a handful of these form elements per page, and that we unload pages that aren't visible, I'm not sure if this really is a going to be a big problem.
Unfortunately I've not got a better idea off the top of my head, so let's do this for now (and I'll try to fix the standalone PDFPageView case in a follow-up).

Snuffleupagus · 2021-08-05T08:45:23Z

/botio makeref

pdfjsbot · 2021-08-05T08:45:24Z

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/ec51d41b2f106da/output.txt

pdfjsbot · 2021-08-05T08:45:24Z

From: Bot.io (Windows)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://3.101.106.178:8877/3b5b2ff0aff2b0f/output.txt

pdfjsbot · 2021-08-05T09:15:47Z

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/ec51d41b2f106da/output.txt

Total script time: 30.38 mins

Lint: Passed
Make references: Passed
Check references: Passed

pdfjsbot · 2021-08-05T09:22:15Z

From: Bot.io (Windows)

Success

Full output at http://3.101.106.178:8877/3b5b2ff0aff2b0f/output.txt

Total script time: 36.84 mins

Lint: Passed
Make references: Passed
Check references: Passed

calixteman requested a review from Snuffleupagus August 4, 2021 12:48

Snuffleupagus requested changes Aug 4, 2021

View reviewed changes

calixteman force-pushed the zoom_select branch from 12ec1e1 to 68f9b0f Compare August 4, 2021 13:31

calixteman force-pushed the zoom_select branch from 68f9b0f to 684217e Compare August 4, 2021 15:34

Annotation & XFA: Scale the font size in choicelist using zoom factor…

71a100a

… (bug 1715996) - this is an accessibility issue which could be painful for some people with visual disabilities.

calixteman force-pushed the zoom_select branch from 684217e to 71a100a Compare August 4, 2021 18:37

Snuffleupagus merged commit 4ad65c8 into mozilla:master Aug 5, 2021

timvandermeij added annotations form-xfa labels Aug 5, 2021

Annotation & XFA: Scale the font size in choicelist using zoom factor (bug 1715996) #13868

Annotation & XFA: Scale the font size in choicelist using zoom factor (bug 1715996) #13868

Conversation

calixteman commented Aug 4, 2021

Snuffleupagus Aug 4, 2021

Choose a reason for hiding this comment

Snuffleupagus Aug 4, 2021

Choose a reason for hiding this comment

Snuffleupagus commented Aug 4, 2021

pdfjsbot commented Aug 4, 2021

From: Bot.io (Linux m4)

Received

pdfjsbot commented Aug 4, 2021

From: Bot.io (Windows)

Received

pdfjsbot commented Aug 4, 2021

From: Bot.io (Windows)

Failed

pdfjsbot commented Aug 4, 2021

From: Bot.io (Linux m4)

Failed

Snuffleupagus commented Aug 4, 2021

calixteman commented Aug 4, 2021

calixteman commented Aug 4, 2021

pdfjsbot commented Aug 4, 2021

From: Bot.io (Linux m4)

Received

pdfjsbot commented Aug 4, 2021

From: Bot.io (Windows)

Received

pdfjsbot commented Aug 4, 2021

From: Bot.io (Linux m4)

Failed

Snuffleupagus commented Aug 4, 2021 • edited Loading

pdfjsbot commented Aug 4, 2021

From: Bot.io (Windows)

Failed

calixteman commented Aug 4, 2021

pdfjsbot commented Aug 4, 2021

From: Bot.io (Linux m4)

Received

pdfjsbot commented Aug 4, 2021

From: Bot.io (Windows)

Received

pdfjsbot commented Aug 4, 2021

From: Bot.io (Linux m4)

Failed

calixteman commented Aug 4, 2021

pdfjsbot commented Aug 4, 2021

From: Bot.io (Linux m4)

Received

pdfjsbot commented Aug 4, 2021

From: Bot.io (Windows)

Failed

pdfjsbot commented Aug 4, 2021

From: Bot.io (Linux m4)

Failed

calixteman commented Aug 4, 2021

pdfjsbot commented Aug 4, 2021

From: Bot.io (Linux m4)

Received

pdfjsbot commented Aug 4, 2021

From: Bot.io (Linux m4)

Success

Published

Snuffleupagus commented Aug 4, 2021

calixteman commented Aug 4, 2021

pdfjsbot commented Aug 4, 2021

From: Bot.io (Linux m4)

Received

pdfjsbot commented Aug 4, 2021

From: Bot.io (Windows)

Received

calixteman commented Aug 4, 2021

pdfjsbot commented Aug 4, 2021

From: Bot.io (Linux m4)

Failed

pdfjsbot commented Aug 4, 2021

From: Bot.io (Windows)

Failed

Snuffleupagus commented Aug 4, 2021 •

edited

Loading