Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotation & XFA: Add focus outlines on different fields (bug 1723615, bug 1718528) #13875

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Annotation & XFA: Add focus outlines on different fields (bug 1723615, bug 1718528) #13875

merged 1 commit into from
Aug 5, 2021

Conversation

calixteman
Copy link
Contributor

@calixteman
Annotation & XFA: Add focus outlines on different fields (bug 1723615…
fef939d 
…, bug 1718528)

  - set a default tabindex to be sure they'll be taken into account in the TAB cycle (https://bugzilla.mozilla.org/show_bug.cgi?id=1723615).
  - show default outline when fields are focused (it was an a11y bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1718528).
@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Aug 5, 2021

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/78420e566664b8c/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 5, 2021

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/7c18be9620295aa/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 5, 2021

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/78420e566664b8c/output.txt

Total script time: 25.99 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  errors: 642
  different ref/snapshot: 12

Image differences available at: http://54.67.70.0:8877/78420e566664b8c/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Aug 5, 2021

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/7c18be9620295aa/output.txt

Total script time: 39.32 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 9
  different first/second rendering: 1

Image differences available at: http://3.101.106.178:8877/7c18be9620295aa/reftest-analyzer.html#web=eq.log

@marco-c
Copy link
Contributor

marco-c commented Aug 5, 2021

/botio linux-test

@pdfjsbot
Copy link

pdfjsbot commented Aug 5, 2021

From: Bot.io (Linux m4)

Invalid

Command not implemented: linux.

@pdfjsbot
Copy link

pdfjsbot commented Aug 5, 2021

From: Bot.io (Windows)

Invalid

Command not implemented: linux.

@marco-c
Copy link
Contributor

marco-c commented Aug 5, 2021

/botio-linux test

@pdfjsbot
Copy link

pdfjsbot commented Aug 5, 2021

From: Bot.io (Linux m4)

Received

Command cmd_test from @marco-c received. Current queue size: 0

Live output at: http://54.67.70.0:8877/77421eecfaf0c44/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 5, 2021

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/77421eecfaf0c44/output.txt

Total script time: 26.00 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  errors: 639
  different ref/snapshot: 11
  different first/second rendering: 2

Image differences available at: http://54.67.70.0:8877/77421eecfaf0c44/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

so painful...
/botio-linux test

@pdfjsbot
Copy link

pdfjsbot commented Aug 5, 2021

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/9fb3ab86ab369ff/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 5, 2021

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/9fb3ab86ab369ff/output.txt

Total script time: 33.31 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 9
  different first/second rendering: 1

Image differences available at: http://54.67.70.0:8877/9fb3ab86ab369ff/reftest-analyzer.html#web=eq.log

@marco-c
Copy link
Contributor

marco-c commented Aug 5, 2021

Finally no intermittent errors!

@calixteman
Copy link
Contributor Author

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Aug 5, 2021

From: Bot.io (Linux m4)

Received

Command cmd_preview from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/56fe2ec8bfdcd13/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 5, 2021

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/56fe2ec8bfdcd13/output.txt

Total script time: 5.13 mins

Published

@calixteman calixteman merged commit 834e475 into mozilla:master Aug 5, 2021
@calixteman calixteman deleted the xfa_focus branch August 5, 2021 18:09
@marco-c marco-c linked an issue Sep 30, 2021 that may be closed by this pull request
PDF Fill - TAB-navigation, not highlighting checkboxes #12223
Closed
@marco-c marco-c mentioned this pull request Mar 3, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus left review comments

@marco-c marco-c marco-c approved these changes

Assignees
No one assigned
Labels
annotations form-xfa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PDF Fill - TAB-navigation, not highlighting checkboxes
5 participants
@calixteman @pdfjsbot @marco-c @Snuffleupagus @timvandermeij