Re-factor loadAndEnablePDFBug and PDFBug.init
#13905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `loadAndEnablePDFBug` helper function, in `web/app.js`, can be simplified a little bit by making it `async`. Furthermore, given how `PDFBug` is being used, we can also (slightly) re-factor `PDFBug.init` such that the `PDFBug.enable`-call is done internally rather than having to handle that manually at the call-site. (Finally, utilize `await` more in the `loadFakeWorker` helper function.)
Snuffleupagus
force-pushed
the
refactor-loadAndEnablePDFBug
branch
from
f6a97f1
to
bc8787b
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/ab0321bfe2ea4e5/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/ab0321bfe2ea4e5/output.txt Total script time: 5.11 mins Published |
timvandermeij
approved these changes
Aug 21, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
loadAndEnablePDFBughelper function, inweb/app.js, can be simplified a little bit by making itasync. Furthermore, given howPDFBugis being used, we can also (slightly) re-factorPDFBug.initsuch that thePDFBug.enable-call is done internally rather than having to handle that manually at the call-site.(Finally, utilize
awaitmore in theloadFakeWorkerhelper function.)