Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the ESLint object-shorthand rule in the extensions/chromium/-folder #13922

Merged

Conversation

Snuffleupagus
Copy link
Collaborator

Based on the following compatibility information, there can't be any compelling reason to not enable this ESLint rule now: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Object_initializer#browser_compatibility

See also https://eslint.org/docs/rules/object-shorthand

@Snuffleupagus
Copy link
Collaborator Author

/botio lint

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_lint from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/9df464e933d8e07/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_lint from @Snuffleupagus received. Current queue size: 0

Live output at: http://3.101.106.178:8877/2a15a0eb563ba29/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/9df464e933d8e07/output.txt

Total script time: 2.55 mins

  • Lint: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://3.101.106.178:8877/2a15a0eb563ba29/output.txt

Total script time: 4.30 mins

  • Lint: Passed

@timvandermeij timvandermeij merged commit d022333 into mozilla:master Aug 22, 2021
@timvandermeij
Copy link
Contributor

More standardization, nice!

@Snuffleupagus Snuffleupagus deleted the eslint-object-shorthand-chromium branch August 22, 2021 12:54
@Snuffleupagus
Copy link
Collaborator Author

More standardization, nice!

Thank you!
I'm guessing that we could probably enable no-var as well, but that would likely require a bunch of manual changes as well (hence not something that I'll prioritize working on myself):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants