Fix saving of XFA checkboxes. (bug 1726381)

[brendandahl]

Previously were were always setting the storage value to the on value.

I'd like to add a test for this, but it's proving difficult to intercept the save file. My plan is to add a mozilla central test since we already have some tests for saving acroforms there.

[Snuffleupagus]

/botio-linux preview

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/1a39370a448366e/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.67.70.0:8877/1a39370a448366e/output.txt

Total script time: 5.16 mins

Published

• Viewer: http://54.67.70.0:8877/1a39370a448366e/web/viewer.html
• Viewer (legacy): http://54.67.70.0:8877/1a39370a448366e/legacy/web/viewer.html

[Snuffleupagus]

/botio xfatest

[Snuffleupagus]

This looks reasonable as far as I understand, and in my (manual) testing it seems to work nicely; thank you!

[timvandermeij]

/botio integrationtest

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/93ce6e58033d079/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://3.101.106.178:8877/2fcc21e50c152f2/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.67.70.0:8877/93ce6e58033d079/output.txt

Total script time: 4.49 mins

• Integration Tests: Passed

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://3.101.106.178:8877/2fcc21e50c152f2/output.txt

Total script time: 6.78 mins

• Integration Tests: FAILED

[timvandermeij]

Looks good to me too. Thank you!