Annotation - Checkboxes with the same name and export values must be in unison #14027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test I'll write for #14023 will test the current patch. |
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/5e606d7e0eae0c3/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d131b17d4daadaf/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/d131b17d4daadaf/output.txt Total script time: 3.79 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/5e606d7e0eae0c3/output.txt Total script time: 5.72 mins
|
Snuffleupagus
approved these changes
Sep 15, 2021
src/display/annotation_layer.js
Outdated
| if (value) { | ||
| element.setAttribute("checked", true); | ||
| } | ||
| element.setAttribute("id", id); | ||
| element.setAttribute("acroformExportValue", data.exportValue); |
There was a problem hiding this comment.
The attribute name feels a bit verbose to me; any reason that just exportValue wouldn't work?
…in unison - it aims to fix mozilla#14024. - this patch adds an attribute `acroformExportValue` to the HTML input in order to set the checked attribute in taking into account the exportValue for the checkboxes with the same name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
acroformExportValueto the HTML input in order to set the checked attribute in taking into account the exportValue for the checkboxes with the same name.