JS - Implement few possibilities with app.execMenuItem (bug 1724399) #14038
Conversation
calixteman
force-pushed
the
saveas
branch
2 times, most recently
from
959a624
to
29e05ab
Compare
calixteman
changed the title
web/pdf_scripting_manager.js
Outdated
| this._eventBus.dispatch("save", { source: this }); | ||
| break; | ||
| case "FirstPage": | ||
| this._eventBus.dispatch("firstpage", { source: this }); |
There was a problem hiding this comment.
Events should only be used for things that the BaseViewer doesn't directly support, and which require the full viewer (such as e.g. saving).
For everything else, please use direct this._pdfViewer calls wherever possible to avoid breaking the standalone viewer components unnecessarily; note https://github.com/mozilla/pdf.js/tree/master/examples/components
Hence, for the FirstPage, LastPage, NextPage, and PrevPage event specifically: please revert to the previous version of this PR (with my two comments addressed).
| case "PrevPage": | ||
| this._pdfViewer.previousPage(); | ||
| break; | ||
| case "ZoomViewIn": |
There was a problem hiding this comment.
Similar to the "zoom"-case in the existing code, please add the following check to prevent issues:
if (isInPresentationMode) {
return;
}| case "ZoomViewIn": | ||
| this._eventBus.dispatch("zoomin", { source: this }); | ||
| break; | ||
| case "ZoomViewOut": |
src/scripting_api/app.js
Outdated
| if ( | ||
| [ | ||
| "SaveAs", | ||
| "FirstPage", | ||
| "LastPage", | ||
| "NextPage", | ||
| "PrevPage", | ||
| "ZoomViewIn", | ||
| "ZoomViewOut", | ||
| ].includes(item) | ||
| ) { | ||
| this._send({ command: item }); | ||
| return; | ||
| } | ||
|
|
||
| switch (item) { | ||
| case "FitPage": | ||
| this._send({ command: "zoom", value: "page-fit" }); | ||
| break; | ||
| case "Print": | ||
| this._send({ command: "print" }); | ||
| break; | ||
| } |
There was a problem hiding this comment.
Now that the switch is added, can't you simply handle all of the cases within that block instead?
switch (item) {
case "SaveAs":
case "FirstPage":
case "LastPage":
case "NextPage":
case "PrevPage":
case "ZoomViewIn":
case "ZoomViewOut":
this._send({ command: item });
break;
case "FitPage":
this._send({ command: "zoom", value: "page-fit" });
break;
case "Print":
this._send({ command: "print" });
break;
}
Can be tested with https://github.com/mozilla/pdf.js/blob/master/test/pdfs/evaljs.pdf
Enter
app.execMenuItem("SaveAs")in the first field and then click on the buttonExecute.