Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XFA - Create a new page in case of overflow #14072

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

calixteman
Copy link
Contributor

  - it aims to fix mozilla#14071;
  - a subform is overflowing and the the target in case of overflow is itself. In this case we must create a new page.
@calixteman
Copy link
Contributor Author

/botio xfatest

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_xfatest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/f9867cff0fe30d3/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_xfatest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/e9ea2c20bce3126/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/e9ea2c20bce3126/output.txt

Total script time: 9.08 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 6

Image differences available at: http://54.241.84.105:8877/e9ea2c20bce3126/reftest-analyzer.html#web=eq.log

@marco-c
Copy link
Contributor

marco-c commented Sep 24, 2021

The contents of the "Badge details" section disappeared in firefox-xfa_bug1717668_2-page1.

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/f9867cff0fe30d3/output.txt

Total script time: 16.21 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 7

Image differences available at: http://54.193.163.58:8877/f9867cff0fe30d3/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

The contents of the "Badge details" section disappeared in firefox-xfa_bug1717668_2-page1.

Yeah I checked locally and before the patch this stuff was duplicated on page 1 and 2. With the patch it's only on page 2.
Anyway this stuff should appear/disappear thanks to some JS actions so it's pretty impossible to know what it's really correct here.

@calixteman
Copy link
Contributor Author

/botio unittest

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5da44f435f61b9e/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_unittest from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/502648f26c627b3/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/5da44f435f61b9e/output.txt

Total script time: 2.80 mins

  • Unit Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/502648f26c627b3/output.txt

Total script time: 6.48 mins

  • Unit Tests: Passed

@calixteman calixteman merged commit e4d62db into mozilla:master Sep 24, 2021
@calixteman
Copy link
Contributor Author

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d7413dab10a4803/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @calixteman received. Current queue size: 2

Live output at: http://54.193.163.58:8877/e9eae26e243ddb8/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/d7413dab10a4803/output.txt

Total script time: 20.04 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/e9eae26e243ddb8/output.txt

Total script time: 37.63 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XFA - Overflow is not rendered on the next page
4 participants