[api-minor] Ensure that various URL-related options are applied in the xfaLayer too
#14092
Conversation
Snuffleupagus
changed the title
xfaLayer tooxfaLayer too
Snuffleupagus
force-pushed
the
xfa-addLinkAttributes
branch
3 times, most recently
from
51e7a76
to
d2950ce
Compare
|
/botio xfatest |
Snuffleupagus
force-pushed
the
xfa-addLinkAttributes
branch
2 times, most recently
from
6fd4ea4
to
5147294
Compare
|
/botio xfatest |
From: Bot.io (Linux m4)ReceivedCommand cmd_xfatest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b8ef7943cb910f3/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_xfatest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/babe5c0009822d7/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/b8ef7943cb910f3/output.txt Total script time: 9.35 mins
Image differences available at: http://54.241.84.105:8877/b8ef7943cb910f3/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/babe5c0009822d7/output.txt Total script time: 16.08 mins
Image differences available at: http://54.193.163.58:8877/babe5c0009822d7/reftest-analyzer.html#web=eq.log |
|
Flagging multiple reviewers, since there's basically two parts to this:
|
… too Note how both the annotationLayer and the document outline will apply various URL-related options when creating the link-elements. For consistency the `xfaLayer`-rendering should obviously use the same options, to ensure that the existing options are indeed applied to all URLs regardless of where they originate.
Snuffleupagus
force-pushed
the
xfa-addLinkAttributes
branch
from
5147294
to
bc21086
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_xfatest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/e0666ab188112c3/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_xfatest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/20e118bab1edd6d/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/e0666ab188112c3/output.txt Total script time: 9.41 mins
Image differences available at: http://54.241.84.105:8877/e0666ab188112c3/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/20e118bab1edd6d/output.txt Total script time: 16.27 mins
Image differences available at: http://54.193.163.58:8877/20e118bab1edd6d/reftest-analyzer.html#web=eq.log |
… the API, to the `PDFLinkService` implementations This patch helps reduce some duplication, given that we now have a few essentially identical `addLinkAttributes` call-sites in the code-base. To prevent runtime errors in the Annotation/XFA-layer code, we'll warn if a custom/incomplete `PDFLinkService` is being used (limited to GENERIC builds).
Snuffleupagus
force-pushed
the
xfa-addLinkAttributes
branch
from
bc21086
to
8cb6efe
Compare
|
Thanks! |
Note how both the annotationLayer and the document outline will apply various URL-related options when creating the link-elements.
For consistency the
xfaLayer-rendering should obviously use the same options, to ensure that the existing options are indeed applied to all URLs regardless of where they originate.