Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace a couple of Array.prototype.forEach-invocations with for..of instead #14095

Merged

Conversation

Snuffleupagus
Copy link
Collaborator

Given that NodeLists can be iterated using for..of we can use that instead, since it's a little bit nicer and easier to read than the Array.prototype.forEach format.

…of` instead

Given that `NodeList`s can be iterated using `for..of` we can use that instead, since it's a little bit nicer and easier to read than the `Array.prototype.forEach` format.
@Snuffleupagus
Copy link
Collaborator Author

/botio integrationtest

@pdfjsbot
Copy link

pdfjsbot commented Oct 1, 2021

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/b89890a36758282/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Oct 1, 2021

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/3037de82c39fb58/output.txt

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@pdfjsbot
Copy link

pdfjsbot commented Oct 1, 2021

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/b89890a36758282/output.txt

Total script time: 3.80 mins

  • Integration Tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Oct 1, 2021

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/3037de82c39fb58/output.txt

Total script time: 5.37 mins

  • Integration Tests: FAILED

@Snuffleupagus
Copy link
Collaborator Author

/botio integrationtest

@pdfjsbot
Copy link

pdfjsbot commented Oct 1, 2021

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/9ed7cd1ff156202/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Oct 1, 2021

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/cd51063836ab03e/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Oct 1, 2021

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/9ed7cd1ff156202/output.txt

Total script time: 3.79 mins

  • Integration Tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Oct 1, 2021

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/cd51063836ab03e/output.txt

Total script time: 6.15 mins

  • Integration Tests: FAILED

@Snuffleupagus
Copy link
Collaborator Author

/botio-windows integrationtest

@pdfjsbot
Copy link

pdfjsbot commented Oct 1, 2021

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/8ec94cf9b83811b/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Oct 1, 2021

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/8ec94cf9b83811b/output.txt

Total script time: 6.03 mins

  • Integration Tests: Passed

@Snuffleupagus
Copy link
Collaborator Author

/botio-windows integrationtest

@pdfjsbot
Copy link

pdfjsbot commented Oct 1, 2021

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/b3b4c35342f0be6/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Oct 1, 2021

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/b3b4c35342f0be6/output.txt

Total script time: 6.02 mins

  • Integration Tests: Passed

@Snuffleupagus Snuffleupagus merged commit d588f5f into mozilla:master Oct 1, 2021
@Snuffleupagus Snuffleupagus deleted the annotationLayer-rm-forEach branch October 1, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants