-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace a couple of Array.prototype.forEach
-invocations with for..of
instead
#14095
Replace a couple of Array.prototype.forEach
-invocations with for..of
instead
#14095
Conversation
…of` instead Given that `NodeList`s can be iterated using `for..of` we can use that instead, since it's a little bit nicer and easier to read than the `Array.prototype.forEach` format.
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b89890a36758282/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/3037de82c39fb58/output.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/b89890a36758282/output.txt Total script time: 3.80 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/3037de82c39fb58/output.txt Total script time: 5.37 mins
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9ed7cd1ff156202/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/cd51063836ab03e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/9ed7cd1ff156202/output.txt Total script time: 3.79 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/cd51063836ab03e/output.txt Total script time: 6.15 mins
|
/botio-windows integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/8ec94cf9b83811b/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/8ec94cf9b83811b/output.txt Total script time: 6.03 mins
|
/botio-windows integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/b3b4c35342f0be6/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/b3b4c35342f0be6/output.txt Total script time: 6.02 mins
|
Given that
NodeList
s can be iterated usingfor..of
we can use that instead, since it's a little bit nicer and easier to read than theArray.prototype.forEach
format.