Remove the unused skipCount parameter from Catalog.getPageDict (PR 14311 follow-up)
#14325
Conversation
…R 14311 follow-up) This was added in PR 14311, but given that I completely missed to update the `PDFDocument.getPage` signature accordingly it's completely unused. Given that things work just as fine as-is, let's simply remove that optional parameter for now; sorry about the churn here!
…e" unit-test (PR 14304 follow-up) Given that we're able to "render" this document, let's extend the unit-test to actually check that we're able to obtain the operatorList; although given the overall issues in the document it'll be empty.
Snuffleupagus
force-pushed
the
getPageDict-rm-skipCount
branch
from
cf0c32b
to
8ea740c
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/c6aec3e1fef3a6b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/b20a88c4cb64dcd/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/c6aec3e1fef3a6b/output.txt Total script time: 21.78 mins
Image differences available at: http://54.241.84.105:8877/c6aec3e1fef3a6b/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/b20a88c4cb64dcd/output.txt Total script time: 41.90 mins
Image differences available at: http://54.193.163.58:8877/b20a88c4cb64dcd/reftest-analyzer.html#web=eq.log |
|
@calixteman If you've got time, mind reviewing (or basically rubber-stamping) these changes? |
Remove the unused
skipCountparameter fromCatalog.getPageDict(PR 14311 follow-up)This was added in PR [api-minor] Validate the /Pages-tree /Count entry during document initialization (issue 14303) #14311, but given that I completely missed to update the
PDFDocument.getPagesignature accordingly it's completely unused.Given that things work just as fine as-is, let's simply remove that optional parameter for now; sorry about the churn here!
Slightly extend the "creates pdf doc from PDF file with bad XRef table" unit-test (PR 14304 follow-up)
Given that we're able to "render" this document, let's extend the unit-test to actually check that we're able to obtain the operatorList; although given the overall issues in the document it'll be empty.